vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Published 20 hours ago • verified publisher icon borgbase

feat: Added change passphrase dialog

Open jetchirag opened this issue 2 years ago • 9 comments
trafficstars

Description

A way to change the password I provided when the repo were created.

Related Issue

Fixes #303

How Has This Been Tested?

Manually tested with local repos. Pending more extensive testing.

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] I have read the CONTRIBUTING guide.
  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

jetchirag avatar Mar 17 '23 11:03 jetchirag

I was thinking that we could use a common widget (a self-implemented one) for all password entries in vorta. Can you implement such thing?

real-yfprojects avatar Mar 17 '23 15:03 real-yfprojects

@real-yfprojects I am assuming password marking, visibility toggle and validation etc in the widget. Should I subclass QLineEdit?

jetchirag avatar Mar 17 '23 16:03 jetchirag

No, I wouldn't do that you can subclass QWidget and add a layout with the widgets.

real-yfprojects avatar Mar 17 '23 16:03 real-yfprojects

Okay I'll open a new PR for widget after closing this.

jetchirag avatar Mar 17 '23 18:03 jetchirag

I've added 2 new tests but currently the test repo doesn't have encryption so it would run mock command on non-encrypted repo. I can add another repo but it doesn't seem necessary since in GUI button is disabled.

jetchirag avatar Mar 18 '23 11:03 jetchirag

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 19 '23 06:07 stale[bot]

This can now be updated to use the new widgets you implemented @jetchirag

real-yfprojects avatar Aug 01 '23 08:08 real-yfprojects

Done ✅

jetchirag avatar Aug 08 '23 18:08 jetchirag

Just noticed merge conflict. Will solve them.

jetchirag avatar Aug 09 '23 19:08 jetchirag