borgbase
[Enhancement] Avoid blocking UI while adding existing repo
Description
Related Issue
Closes #1306
Motivation and Context
When adding a existing repository the UI freezes, this change might solve this issue
How Has This Been Tested?
I've tested this by adding a repository which is used to crash the UI
Screenshots (if appropriate):
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] I have read the CONTRIBUTING guide.
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.
Hi! @real-yfprojects , is this right ? like the UI is not freezing now, but after reverting back to the old changes I cant reproduce the issue anymore, I've tried editing the settings.db and even deleted the testing version. Any clue what I did wrong ?
the UI is not freezing now, but after reverting back to the old changes I cant reproduce the issue anymore
I don't know what you were experiencing before, but this looks good. What happens when you close the dialog, the main window, quit vorta or try to edit anything inside vorta?
the UI is not freezing now, but after reverting back to the old changes I cant reproduce the issue anymore
I don't know what you were experiencing before, but this looks good. What happens when you close the dialog, the main window, quit vorta or try to edit anything inside vorta?
Hi! Actually that was my mistake 😓 , I was running vorta from the backup repo and reverted the changes in main repo 😓
But is this the required solution ? like are there more changes required ?
But is this the required solution ? like are there more changes required ?
As I said. This is the right approach. What happens when you close the dialog, the main window or quit vorta?
Hi! this seems to work on my machine! waiting for your review 😄
also I've had a question about migrations, how can I perform the migrations 🤔
@m3nu What was your Intention with the PR, would you consider it fine when the GUI stays responsive but you still can't do anything else while borg is running?
This code was written long ago. It didn't seem important to do, anything else, while adding a repo. No specific consideration.
This code was written long ago. It didn't seem important to do, anything else, while adding a repo. No specific consideration.
But as per the current GUI, you can not do anything until you close the dialog displayed 🤔
also I've had a question about migrations, how can I perform the migrations thinking
Which migrations? Usually vorta migrates its database automatically.
also I've had a question about migrations, how can I perform the migrations thinking
Which migrations? Usually vorta migrates its database automatically.
Oh, okay, means whenever I run vorta it applies the migrations ?
I noticed that the
cancelbutton no longer works.
when we try to cancel (close) the add repo dialog without hitting the OK? I noticed that too, I added a try-except block for that in cancel_job 👍🏼 I'll push the code once the default queue change is done 😄
I noticed that the
cancelbutton no longer works.
The cancel button should work now 👍🏼
Hi! and sorry I was away leaving this PR open with no activity, I was actually having my Practical exams 😅
I've updated the code accordingly, waiting for your review @real-yfprojects 😄
Pls also show a status message while borg init/borg info is running.
Pls also show a status message while
borg init/borg infois running.
Sorry! did not get that exactly
Pls also show a status message while
borg init/borg infois running.
Hi! Did you mean, while the app is backing up the data? l instead of messages like Received SIGTERM or ERROR: Connection closed by remote host it should show Cancelled Adding Repository ? Because it shows the Cancelled adding repository message in AddRepoDialog 🤔
No it should show a message while the repository is accessed (verified) for the first time. Something like Adding repository or something more specific and preferably progress updates if available.
Hi! @real-yfprojects, sorry, this is taking longer than expected, I'm completely engrossed in preparation of my upcoming semester exam from May 8th. I will be completing this in a slow pace till then.
Sorry for inconvenience :)