vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Published 20 hours ago • verified publisher icon borgbase

Notifications improvement.

Open real-yfprojects opened this issue 2 years ago • 7 comments
trafficstars

Closes #609.

I went a bit overboard and reimplemented the notifications module. It now supports the full org.freedesktop.Notifications feature set and uses the new MacOS UserNotifications API. The symbolic icon added in #563 is removed because notifications use the normal app icon afaik.

It would be a miracle if the MacOS code worked. Testing and fixing it is up to you. The linux code works as expected:

Bildschirmfoto vom 2022-12-28 08-36-07 notification-screenshot

real-yfprojects avatar Dec 28 '22 08:12 real-yfprojects

The linux code works as expected

I also checked XFCE. Works and looks very similar to GNOME.

real-yfprojects avatar Jan 21 '23 10:01 real-yfprojects

@m3nu Have you got time for this in the near future? Or should I exclude the MacOS changes from this PR?

real-yfprojects avatar Feb 18 '23 17:02 real-yfprojects

Nice rewrite. Will work on it for macOS of course.

m3nu avatar Feb 18 '23 20:02 m3nu

Fixed up macOS notifications to the point where they don't cause an error and open the main window when clicked.

m3nu avatar Feb 19 '23 12:02 m3nu

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jul 19 '23 06:07 stale[bot]

This is definitely still needed - https://github.com/borgbase/vorta/issues/1773

sammcj avatar Aug 13 '23 22:08 sammcj

Yeah, the Linux part is all done, but the MacOS code needs to be tested and completed. I can't do that because I dont have MacOS.

real-yfprojects avatar Aug 14 '23 07:08 real-yfprojects