vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Clear contents of `logText` after successful backup.

Open real-yfprojects opened this issue 2 years ago • 1 comments

Currently the label logText is not cleared after a borg command finished. When creating a backup the label will show the path of the last backuped file even after backup completion.

Instead the progressText and logText labels should be cleared if they show information only relevant during the command execution.

real-yfprojects avatar Aug 14 '22 16:08 real-yfprojects

This was already reported here: https://github.com/borgbase/vorta/issues/1356#issuecomment-1157515164

real-yfprojects avatar Aug 14 '22 16:08 real-yfprojects

Hey @real-yfprojects can I work on this issue?

aadityasinha-dotcom avatar Feb 26 '23 02:02 aadityasinha-dotcom

Sure, you'll need to be familiar with (py)qt signals for this one.

real-yfprojects avatar Feb 26 '23 13:02 real-yfprojects

Hey, @real-yfprojects can you explain me about this issue?

aadityasinha-dotcom avatar Feb 28 '23 17:02 aadityasinha-dotcom

Hey, @real-yfprojects can you explain me about this issue?

What is your question?

real-yfprojects avatar Feb 28 '23 19:02 real-yfprojects

Hey! @aadityasinha-dotcom are you still working on this ? otherwise I would like to work on this

DaffyTheDuck avatar Mar 03 '23 11:03 DaffyTheDuck

Yes

aadityasinha-dotcom avatar Mar 03 '23 11:03 aadityasinha-dotcom

Hey, @real-yfprojects can you explain me about this issue?

I guess @real-yfprojects means something like this

log_text

See the bottom text disappears after the job is finished 😄

DaffyTheDuck avatar Mar 03 '23 11:03 DaffyTheDuck

See the bottom text disappears after the job is finished

That is the goal. Vorta doesn't do this yet afaik.

real-yfprojects avatar Mar 03 '23 12:03 real-yfprojects

okay got it, thank you @DaffyTheDuck

aadityasinha-dotcom avatar Mar 03 '23 12:03 aadityasinha-dotcom

https://user-images.githubusercontent.com/75474786/222726002-8366c311-a68f-4844-928a-7bd66faeae6d.mp4

But in my system it does not disappears

aadityasinha-dotcom avatar Mar 03 '23 12:03 aadityasinha-dotcom

But in my system it does not disappears

That's what you have to figure out 😄

DaffyTheDuck avatar Mar 03 '23 18:03 DaffyTheDuck

@real-yfprojects can you explain this?

aadityasinha-dotcom avatar Mar 05 '23 08:03 aadityasinha-dotcom

can you explain this?

this is an ambiguous pronoun. Be more specific with your question. State what you have already figured out. What problems you are facing and what kind of advice you are expecting.

If I tell you in detail what lines of code have to be written. I can just write the code instead.

real-yfprojects avatar Mar 05 '23 09:03 real-yfprojects

@real-yfprojects can you explain this?

In simple, he means that you've to modify the code in such a way that it should remove the labels after the backup is complete 😄 (you can also tweak the code in a way that as shown in my gif it wont remove it instantly)

DaffyTheDuck avatar Mar 05 '23 09:03 DaffyTheDuck

okay

aadityasinha-dotcom avatar Mar 05 '23 09:03 aadityasinha-dotcom

But my question is, why it is not disappearing in my system? @DaffyTheDuck

aadityasinha-dotcom avatar Mar 05 '23 09:03 aadityasinha-dotcom

But my question is, why it is not disappearing in my system? @DaffyTheDuck

Because I've modified the code in my system which doesn't exists in main repository, your system contains the code from main repository, so to close this issue you've to modify the code in your system and push the changes so @real-yfprojects and @m3nu can review it 😄

DaffyTheDuck avatar Mar 05 '23 09:03 DaffyTheDuck

My bad, sorry I got confused what was the goal of this issue. I thought we need not to disappear the text sorry. And thank you for the clarification @DaffyTheDuck

aadityasinha-dotcom avatar Mar 05 '23 09:03 aadityasinha-dotcom

My bad, sorry I got confused what was the goal of this issue. I thought we need not to disappear the text sorry. And thank you for the clarification @DaffyTheDuck

Never Mind 😄 and All The Best 👍🏼

DaffyTheDuck avatar Mar 05 '23 09:03 DaffyTheDuck