vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Request: SMB Support for Repository

Open 53c70r opened this issue 2 years ago • 1 comments

I would like to have the option to add SMB shares with login credentials directly as repository.

53c70r avatar Apr 21 '22 10:04 53c70r

With some restriction you can use the pre and post backup commands to mount the samba shares as far as I know.

real-yfprojects avatar Apr 21 '22 17:04 real-yfprojects

So as i have truenas running and would like to use my nas as backuplocation i support this request :D

DSDV avatar Jan 31 '23 20:01 DSDV

If pre/post commands work for this, this issue should be closed.

Also, this is not about "SMB Support", but just about mounting a cifs/smbfs (or any other network or local filesystem).

ThomasWaldmann avatar Mar 04 '23 12:03 ThomasWaldmann

I dont think so. The SMB/CIFS is successfully mounted. But Vorta does not work with it.

DSDV avatar Mar 04 '23 13:03 DSDV

Why not?

ThomasWaldmann avatar Mar 04 '23 14:03 ThomasWaldmann

Because as i said mounting the SMD/CIFS works great in the OS just not in Vorta. ergo Vorta needs support for SMB Shares so we can create and use backup repositorys over the network (:

DSDV avatar Mar 04 '23 14:03 DSDV

https://github.com/borgbase/vorta/issues/1268#issuecomment-1105506311 what exactly does not work with this?

ThomasWaldmann avatar Mar 04 '23 15:03 ThomasWaldmann

If you click on add new repository and choose a smb share the program freezes. If you write the path by hand its says "unable to create repository"

i am no developer therefor i sadly cannot tell you what does not work or how to fix it :(

DSDV avatar Mar 04 '23 15:03 DSDV

You must give a normal filesystem path.

ThomasWaldmann avatar Mar 04 '23 18:03 ThomasWaldmann

  1. so the menu is broken since it cant pick the correct path?
  2. what is the "normal filesystem path" for SMB/CIFS in your opinion?

DSDV avatar Mar 04 '23 20:03 DSDV

/mnt/samba/borg_repo

or where ever you mounted the cifs.

ThomasWaldmann avatar Mar 04 '23 21:03 ThomasWaldmann

according to terminal the path is "/run/us/1/gvfs/smb-share:server=10.0.0.15,share=sharename" which also does not work.

anyways when the open dialogue of a program does not work and freezes the program its a bug in my book ;) therefor this issue should not be closed as suggested by you. The UI does not work and even crashes vorta!

DSDV avatar Mar 04 '23 22:03 DSDV

You didn't do what was suggested above.

pre-command something like:

sudo mount -t cifs -o username=...,password=... //10.0.0.15/sharename /mnt/samba 

post-command something like:

sudo umount /mnt/samba 

I didn't try it, you might need to tweak the options a bit. See also: https://wiki.ubuntuusers.de/mount.cifs/ and the man page.

There is no reason why borg would not work with a repo in some local or remote filesystem IF the filesystem behaves normally (and permissions are set up correctly).

ThomasWaldmann avatar Mar 05 '23 04:03 ThomasWaldmann

As i said i am no developer! If it is truly desired behavior that a program crashes when you use tho open dialog i cant trust that program with my backups. Simple as that. If i somehow missed that this program is early access i am deeply sorry.

otherwise pls add a note that its only meant for people who are devs. (i now don't wonder anymore where "the Linux reputation" comes from :( ).

as i stated above i expect a open dialog not to crash a program and work as expected and described by the program itself. i have nothing to add here.

DSDV avatar Mar 05 '23 07:03 DSDV

AFAIK borg supports cvfs mounted sambashares. The logs might help debugging this. I suggest you open a new issue and fill in the report form.

real-yfprojects avatar Mar 05 '23 07:03 real-yfprojects

@DSDV This is not about development, but it requires familiarity with linux cli commands.

The goal of this is to reduce layers (== remove gvfs from the equation) and simplify (have a very simple path) by directly using a mounted cifs.

I agree it would be simpler if it "just worked" with the GUI dialogues, but that involves additional stuff and we still do not know what exactly is going wrong, not enough information.

ThomasWaldmann avatar Mar 05 '23 14:03 ThomasWaldmann