vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Translation missing on "Extract" dialog for grid columns and "Extract" button.

Open delfino-nunez opened this issue 3 years ago • 8 comments

Describe the bug The "Extract" dialog grid columns are not translated and the "Extract" button is not translated also.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Archives'
  2. Select an archive from the list
  3. Click on 'Extract'
  4. See untranslated strings

Selection_003

Environment (please complete the following information):

  • OS: Linux 5.13.0-37-generic # 42~20.04.1-Ubuntu SMP Tue Mar 15 15:44:28 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • Vorta version: 0.8.3
  • Installed from: GitHub repo

delfino-nunez avatar Mar 29 '22 04:03 delfino-nunez

The missing translation of the extract button is already fixed. But maybe it hasn't been translated on transifex yet.

real-yfprojects avatar Mar 29 '22 04:03 real-yfprojects

You are right, I see it in the code but is still not in transifex. I'll wait for that to be generated. Thanks.

Selection_005

delfino-nunez avatar Mar 29 '22 05:03 delfino-nunez

You are right, I see it in the code but is still not in transifex. I'll wait for that to be generated. Thanks.

@m3nu Can you push the new source strings to transifex?

real-yfprojects avatar Mar 29 '22 06:03 real-yfprojects

Added you as maintainer and will push shortly. 😄

m3nu avatar Mar 29 '22 08:03 m3nu

Thank you for pushing the strings.

I've create PR #1244, not sure if that the right way to solve this one.

delfino-nunez avatar Mar 30 '22 04:03 delfino-nunez

Added you as maintainer and will push shortly. smile

Great! I can now update the source strings myself - and change the settings which I will only do in consultation with you which is what I will do in the following.

There is an option for transifex projects to translate duplicates automatically. This would save quite some work I think and foster consistency, but might lead to wrong translations if the same string is used in different contexts.

real-yfprojects avatar Mar 30 '22 12:03 real-yfprojects

There is an option for transifex projects to translate duplicates automatically. This would save quite some work I think and foster consistency, but might lead to wrong translations if the same string is used in different contexts.

Feel free to enable it and whatever else makes sense.

m3nu avatar Mar 31 '22 06:03 m3nu

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 10 '22 19:06 stale[bot]

Fixed in d8e4a93cdd527b692869da0969c0fbf43f08305d.

real-yfprojects avatar Nov 10 '22 19:11 real-yfprojects