vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Adjust tray icon behaviour on XFCE.

Open tio-trom opened this issue 3 years ago • 11 comments

This might sound stupid, but I am using it on Arch via the AUR package and if I click the close button it simply minimizes it ti the tray icon area. There I have no right click options. So how do I close Vorta?

tio-trom avatar Feb 20 '22 18:02 tio-trom

You can fully quit it from the system tray menu. There should also be an option und Misc that decides if it will be fully closed when closing the window.

I should note that some desktop envs don't properly show the system tray menu. If that's the case for yours, we can look into making some adjustments.

m3nu avatar Feb 20 '22 18:02 m3nu

I am using XFCE + Arch. Weirdly enough Vorta is the only app so far that shows no menu if I interact with it from the tray panel, and I have tested thousands of apps so far (I curate linux apps too for a project of mine).

In the Misc tab I do not see any option about closing the window: 2022-02-20_20-00

tio-trom avatar Feb 20 '22 19:02 tio-trom

"Display background exit dialog" But not sure this is what you need.

Planning to change the tray behavior for XFCE. See here for full discussion: #938

m3nu avatar Feb 21 '22 06:02 m3nu

Weirdly enough Vorta is the only app so far that shows no menu if I interact with it from the tray panel

Have you used the right mouse button?

real-yfprojects avatar Feb 21 '22 16:02 real-yfprojects

Yes. No mouse button works....

tio-trom avatar Feb 21 '22 16:02 tio-trom

On my VM, the right mouse button will open a context menu provided by xfce. Is that the case for you too?

There is also an option in the preferences of the status notifier plugin called Menu is primary action. Disabling the option makes the intended behaviour of vorta's tray icon working. However, one still cannot open vorta's context menu by right clicking. If the option is enabled, the plugin claims that a left click will open the menu but it seems like this isn't working with Qt.

I therefore suggest that vorta shows the context menu when being activated on xfce.

real-yfprojects avatar Feb 21 '22 18:02 real-yfprojects

"Display background exit dialog" But not sure this is what you need.

I think this one is broken because a don't see any behavioural changes when toggling the option.

real-yfprojects avatar Feb 21 '22 18:02 real-yfprojects

Can do. The desktop env name is in an env var we already use.

m3nu avatar Feb 21 '22 18:02 m3nu

In my XFCE none works. I need to disable the "!Menu is primary action" to be able to open it again from the tray else I can't even bring the window to focus....

tio-trom avatar Feb 21 '22 18:02 tio-trom

In my XFCE none works. I need to disable the "!Menu is primary action" to be able to open it again from the tray else I can't even bring the window to focus....

This is the same behavior for me (xfce, aur). And regardless of all above mentioned options, closing the app only works via task manager or pkill. For context, here's what right click menu looks like:

img

with "Properties" only pointing to general status tray plugin settings.

All other "status tray plugin" entries I tested shipped their very own menu, like for example optimus-manager-qt:

img

And this is what most native (non-status tray plugin) xfce items look like, e.g. pulseaudio:

img

Hope this helps

phil294 avatar Mar 10 '22 19:03 phil294

Can confirm I have the same issue with Vorta 0.8.7 from Debian bullseye-backports with XFCE.

It works as it should with version 0.7.5 from the stable repo.

a544jh avatar Aug 12 '22 14:08 a544jh

Same issue with Vorta 0.8.9 from Xubuntu 22.04.1 (either installed via apt and pip3). Vorta process has to be killed by terminal.

alelapp avatar Jan 08 '23 07:01 alelapp

It is a small inconvenience but quite frustrating to not be able to close it somehow. I opened this issue some 1 year ago, I hope the Vorta devs can add a fix for this sooner. :D

tio-trom avatar Jan 16 '23 13:01 tio-trom

I don't use Xfce myself, but you can open a PR any time. The change will probably go somewhere here:

https://github.com/borgbase/vorta/blob/master/src/vorta/tray_menu.py#L25

m3nu avatar Jan 16 '23 14:01 m3nu

It is a small inconvenience but quite frustrating to not be able to close it somehow. I opened this issue some 1 year ago, I hope the Vorta devs can add a fix for this sooner. :D

Easy changes like this one are tagged good first issue to signal that they suit new contributors. In our very limited time we core developers try to fix more difficult issues.

real-yfprojects avatar Jan 16 '23 15:01 real-yfprojects

I understand guys. The reason I and others hope for a solution soonish is because this is a big issue in XFCE that makes you unable to close Vorta unless you know how to kill the process via a different program. I wish I could help. I do a lot of work on other free projects too, but I can't have the skills to help with this one.

tio-trom avatar Jan 16 '23 15:01 tio-trom

The work here isn't making the change, it's setting up a desktop with XFCE.

I did remember that I run some virtual desktops using XFCE for another project, so might as well use those. Can you summarize what you need again and could you test the changes to verify? Meaning to install a feature branch via pip, as mentioned here: https://vorta.borgbase.com/contributing/#testing-the-current-development-version

m3nu avatar Jan 16 '23 18:01 m3nu

This is just limited to XFCE, as under Gnome the tray icon got a context menu (with extension to activate tray icons).

RubenKelevra avatar Jan 19 '23 12:01 RubenKelevra