vorta icon indicating copy to clipboard operation
vorta copied to clipboard

Flatpak vorta doesn't take the system theme

Open bastiencyr opened this issue 4 years ago • 25 comments

Hello,

Flatpak vorta doesn't take the system theme which result in a bad look for cinnamon users. The theme is the native theme of qt I guess. With the ppa, it works well.

Environment (please complete the following information):

  • OS: Linux Mint cinnamon
  • Vorta version: >=0.7.6
  • Installed from:flatpak and ppa

Thanks :)

bastiencyr avatar Jun 22 '21 10:06 bastiencyr

Always better to use an official package, when available. Be aware that some PPAs are not longer updated. For stability, Debian will be best. For the latest version, pip.

m3nu avatar Jun 26 '21 11:06 m3nu

Anything we can do in Vorta? AFAIK, Flatpak installs its own UI library.

m3nu avatar Jun 26 '21 11:06 m3nu

Always better to use an official package, when available. Be aware that some PPAs are not longer updated. For stability, Debian will be best. For the latest version, pip.

Totally agree for the official package. Unfortunately, the ppa suffer from #859 on Linux platform. pip is fine but no dark mode or native light theme because it is not integrated to the OS.

AFAIK, Flatpak installs its own UI library.

I don't think so. Maybe I missed something in the flatpak doc but regarding to this link : https://docs.flatpak.org/en/latest/desktop-integration.html#theming and this link : https://github.com/flatpak/flatpak/wiki/Extensions, it is possible to use the native theme in the sandbox.

bastiencyr avatar Jun 26 '21 11:06 bastiencyr

Yes, it is possible. But you have to install the same theme via flatpak. Then it should work AFAIK.

Hofer-Julian avatar Jul 11 '21 09:07 Hofer-Julian

@Hofer-Julian Just tried with vlc and same problem. So it may be an issue with Linux Mint. (I already installed the theme via flatpak). I will open an issue on Linux Mint repository. Just a quesiton, is it working with Ubuntu or other distros ? Or someone with Mint ?

bastiencyr avatar Aug 30 '21 10:08 bastiencyr

@bastiencyr i'm under Fedora, running vorta from a flatpak package (com.borgbase.Vorta) and i have problem to just select a source directory. Because it uses the bad file selector, so on a directory, i can "open" on,ly, and not "choose". Also, i'm under Awesome desktop(a tiling WM), and not KDE or Gnome or XFCE4 or any other desktop env... So because of that, i have to use borgmatic in console mode... if not borg-backup directly.

jerome-diver avatar Sep 12 '21 14:09 jerome-diver

Maybe a Flatpak sandbox issue, @Hofer-Julian ?

m3nu avatar Sep 12 '21 16:09 m3nu

Sorry, no idea about "Awesome desktop"...

Hofer-Julian avatar Sep 12 '21 18:09 Hofer-Julian

@Hofer-Julian i removed Flatpak version of Vorta and did install to try other:

  • pyPi (pip3 install) version (i use Python-3.9) is working fine
  • copr (Fedora RPM repo) version is also working fine.

I can conclude maybe that i have no idea why Fatpak version is bugged, but it is bugged and it is not because of Awesome WM. I also not understand what is the fixed solution for this package (because if the bug report is closed, it should be because there is a fix... isn't it ?)

@bastiencyr so your idea is to also send a bug report to Fedora team ? If it only run on your own OS ? I failed to understand the idea. (it is not ironic, i really failed to understand something about the process to close this report)

jerome-diver avatar Sep 13 '21 05:09 jerome-diver

Hello @jerome-diver , I strongly advise you to use the native package of your distribution. To be honest, I dont like flatpak and its an euphemism. I wanted to use flatpak to see how UI of Vorta looks like with the gnome theme because one of my PR do some stuff to the UI. Pip installation is not well integrated too and doesn't take the native theme of the platform.

I posted an issue on the repo of Linux Mint because I dont know where to post this. According to Linux Mint developers, it is is not related to them. But as you said, the native packages work well and is well integrated. Sadly, I don't have response for you. I will continue to search but it's not a priority for me.

bastiencyr avatar Sep 13 '21 15:09 bastiencyr

Hello @m3nu @Hofer-Julian ,

I have some more informations over this subject. Qt app integration in Gnome is made by qt5-style-plugins which contain among other things a gtk2 style. For software installed via apt, there is no problem because they can access files of qt5-style-plugins (probably in /usr). But Flatpak app cant access this, and it seems that there is no package for qt5-style-plugins in flatpak. So a solution is to integrate qt5-style-plugins directly in the flatpak package. Unfortunately, we use PyQt and I didnt find python package of qt5-style. A partial solution can be found here https://stackoverflow.com/questions/63477276/add-qstyles-to-pyqt5 .

Notice that Qt company hasnt updated qt5-style since 4 years ! I think because they focus their effort on QML which has a very good integration in all desktops. The qtstyleplugins is also responsible of integration on other desktops environments such as Mac. So maybe we should consider QML more because I think there will not be gtk3/gtk4 theme for qt or update on mac theme.

bastiencyr avatar Oct 16 '21 20:10 bastiencyr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 19 '21 10:12 stale[bot]

I just gave org.kde.Platform version 5.15 (you are currently using 5.14) a go and it looks MUCH better. Light: grafik Dark: grafik

The only thing that does not look good yet are the dialogs: grafik

But that might be fixed by setting the correct parameters in setParent. This is for example with QtCore.Qt.Dialog instead of QtCore.Qt.Sheet: grafik

I will open a PR for upgrading the runtime now and at some other time another with the dialog parents fixed.

phihos avatar Dec 21 '21 00:12 phihos

One more thing: Since the runtime can not be upgraded due to a bug on Kubuntu it seems there is another way to make the Vorta flatpak distribution look normal again: Make sure to have XWayland installed (usually comes with the distro) and run the following to force Vorta to use it:

sudo flatpak override --nosocket=fallback-x11 --nosocket=wayland --socket=x11 com.borgbase.Vorta

Then restart Vorta and it should look fine.

phihos avatar Jan 01 '22 16:01 phihos

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 03 '22 23:03 stale[bot]

This is still an issue with Vorta 0.10.3. in the Fedora Flathub version I have installed within GNOME Software. Can you please reopen this issue?

sudwhiwdh avatar Apr 19 '25 20:04 sudwhiwdh

@m3nu Thank you very much! Which further information do you need from me to be able to solve the issue?

sudwhiwdh avatar Apr 20 '25 09:04 sudwhiwdh

I don't know, since I don't use any Linux desktop. But if there is any improvement for this we can add in Vorta, someone else may be able to review a PR.

m3nu avatar Apr 20 '25 11:04 m3nu

I don't know, since I don't use any Linux desktop.

I asked because the issue still has a ‘status: needs information’ label.

sudwhiwdh avatar Apr 22 '25 19:04 sudwhiwdh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 22 '25 02:07 github-actions[bot]

Still valid with Vorta 0.10.3, so please reopen the issue.

sudwhiwdh avatar Jul 22 '25 08:07 sudwhiwdh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 21 '25 02:10 github-actions[bot]

This issue was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Oct 29 '25 02:10 github-actions[bot]

@m3nu Please reopen. I hope I won't have to rewrite this message every three months. ;)

sudwhiwdh avatar Oct 29 '25 08:10 sudwhiwdh

No. If an issue has some select tags it will stay open.

m3nu avatar Oct 29 '25 16:10 m3nu