vorta-docker icon indicating copy to clipboard operation
vorta-docker copied to clipboard

Added snippet to generate and install favicons

Open b3rrytech opened this issue 7 months ago • 3 comments

My first ever PR so I hope I've done this right.

I thought the Docker container needed a Vorta favicon instead of the blue box. Followed the instructions for the baseimage from jlesage. The image link is from the Vorta README.md

Maybe it's best to instead add the icon to the repo instead of using this link, but that might need a separate PR first so the link is right?

b3rrytech avatar May 11 '25 01:05 b3rrytech

Looks correct, but it also introduces a dependency on some externally hosted site. Is there a way to have the file inside this repo?

m3nu avatar May 11 '25 12:05 m3nu

Yes the dependency isn’t ideal. I’ll try and do another PR and just adding the icon to this repo first. After that I should be able to change this PR with the url to that icon.

b3rrytech avatar May 11 '25 12:05 b3rrytech

The script works with a local file so we can just add the image to this repo and call the script. Don't close this PR, just add the file in this PR and change the URL

Ranbato avatar May 11 '25 13:05 Ranbato