borg icon indicating copy to clipboard operation
borg copied to clipboard

borg2: msgpack.Unpacker buffer size

Open ThomasWaldmann opened this issue 1 year ago • 1 comments

as borg now uses repository.store_load and .store_save to load and save the chunks index, we need a rather high limit here.

a quick fix is to set this to ~4GiB (the maximum).

the real fix might be using chunks of the data (preferably <= MAX_OBJECT_SIZE), so there is less to unpack at once.

Traceback (most recent call last):
  File "borg/archiver/_common.py", line 176, in wrapper
  File "borg/archiver/create_cmd.py", line 268, in do_create
  File "borg/archiver/create_cmd.py", line 169, in create_inner
  File "borg/archiver/create_cmd.py", line 527, in _rec_walk
  File "borg/archiver/create_cmd.py", line 527, in _rec_walk
  File "borg/archiver/create_cmd.py", line 467, in _rec_walk
  File "borg/archiver/create_cmd.py", line 284, in _process_any
  File "borg/archive.py", line 1381, in process_file
  File "borg/archive.py", line 1142, in process_file_chunks
  File "borg/archive.py", line 1132, in chunk_processor
  File "borg/cache.py", line 754, in add_chunk
  File "borg/cache.py", line 720, in seen_chunk
  File "borg/cache.py", line 716, in chunks
  File "borg/cache.py", line 667, in build_chunkindex_from_repo
  File "borg/remote.py", line 539, in do_rpc
  File "borg/remote.py", line 779, in call
  File "borg/remote.py", line 898, in call_many
  File "msgpack/_unpacker.pyx", line 399, in msgpack._cmsgpack.Unpacker.feed
  File "msgpack/_unpacker.pyx", line 422, in msgpack._cmsgpack.Unpacker.append_buffer
msgpack.exceptions.BufferFull

ThomasWaldmann avatar Oct 01 '24 18:10 ThomasWaldmann

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.0, but it targets 7.0.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Oct 18 '24 15:10 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 8a3671fb3d8fb55ac76981012852f9e78f16f7b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 18 '24 15:10 changeset-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33656/ on branch gh-pages at 2024-10-22 13:05 UTC

github-actions[bot] avatar Oct 18 '24 15:10 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.97%. Comparing base (d69be40) to head (8a3671f). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33656   +/-   ##
========================================
  Coverage    74.97%   74.97%           
========================================
  Files          480      480           
  Lines        21020    21020           
  Branches      5335     5335           
========================================
  Hits         15759    15759           
  Misses        4632     4632           
  Partials       629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 18 '24 15:10 codecov[bot]