borg icon indicating copy to clipboard operation
borg copied to clipboard

BORG_EXIT_CODES=modern as DEFAULT in borg2?

Open ThomasWaldmann opened this issue 1 year ago • 7 comments

borg 1.4 defaults to "legacy".

We could change that for borg2 to "modern", so borg by default gives a lot of specific error and warning exit codes.

Opinions about that?

ThomasWaldmann avatar Feb 20 '24 15:02 ThomasWaldmann

@m3nu @witten @sophie-h

ThomasWaldmann avatar Feb 20 '24 15:02 ThomasWaldmann

Vorta doesn't use them extensively right now. We could add better error messages after this is the default. Right now we only say "Some files couldn't be read, see logs for details" for example.

m3nu avatar Feb 20 '24 15:02 m3nu

@m3nu Thanks for the feedback!

Just as a general note: support for these error/warning codes could be added at any time IF the wrapper checks/sets BORG_EXIT_CODES and reacts accordingly. This would be good, considering that borg >= 1.4 will already optionally support this (and will be released soon).

ThomasWaldmann avatar Feb 20 '24 16:02 ThomasWaldmann

Recent versions of borgmatic set BORG_EXIT_CODES=modern unconditionally, so this proposed change to Borg 2 would be fine from borgmatic's perspective.

witten avatar Feb 20 '24 16:02 witten

@witten Thanks for the feedback.

Just be careful: setting that will only change behaviour for borg >= 1.4.

ThomasWaldmann avatar Feb 20 '24 16:02 ThomasWaldmann

Understood!

witten avatar Feb 20 '24 16:02 witten

Opinions about that?

For 2.0 that's totally fine.

sophie-h avatar Feb 23 '24 13:02 sophie-h