borg icon indicating copy to clipboard operation
borg copied to clipboard

files cache with size

Open ThomasWaldmann opened this issue 2 years ago • 2 comments

ThomasWaldmann avatar Sep 25 '23 20:09 ThomasWaldmann

This is trying to prepare a bigger change in how borg works: giving up with precise refcounting and removing chunk size information from the chunks index/cache (so borg could just work with the set of existing chunks with no further information about them in the chunks index/cache).

A first step into that direction is adding the chunk sizes to the files cache (it currently only has the chunk ids).

If borg create detects a file is unchanged, we need to have that information at hand to create the item's chunk list without reading/chunking the file.

AdHocWithFilesCache tries to be similar to AdHocCache, but additionally has the files cache, so it is super fast for unchanged files. AdHocCache is DEPRECATED now.

ThomasWaldmann avatar Sep 25 '23 20:09 ThomasWaldmann

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.97686% with 74 lines in your changes missing coverage. Please review.

Project coverage is 81.61%. Comparing base (126a346) to head (619a06a). Report is 3 commits behind head on master.

Files Patch % Lines
src/borg/cache.py 80.69% 51 Missing and 16 partials :warning:
src/borg/archive.py 83.87% 4 Missing and 1 partial :warning:
src/borg/archiver/config_cmd.py 0.00% 1 Missing :warning:
src/borg/archiver/rinfo_cmd.py 66.66% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7846      +/-   ##
==========================================
- Coverage   83.76%   81.61%   -2.16%     
==========================================
  Files          67       67              
  Lines       12074    12156      +82     
  Branches     2193     2192       -1     
==========================================
- Hits        10114     9921     -193     
- Misses       1367     1649     +282     
+ Partials      593      586       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 25 '23 21:09 codecov-commenter