borg icon indicating copy to clipboard operation
borg copied to clipboard

1.2 docs: update --prefix to --glob-archives

Open ThomasWaldmann opened this issue 3 years ago • 6 comments

https://borgbackup.readthedocs.io/en/stable/quickstart.html#automating-backups

Warning: "--prefix" has been deprecated. Use "--glob-archives 'yourprefix*'" (-a) instead.

ThomasWaldmann avatar Sep 16 '22 20:09 ThomasWaldmann

Also, we maybe should remove that final line-continuation backslash in the commands.

ThomasWaldmann avatar Sep 16 '22 20:09 ThomasWaldmann

Hello @ThomasWaldmann , I'd love to take this up, but I can't find --prefix in the quickstart file. Could you please show me the file that is to be updated.

Also, I don't understand what you mean here: we maybe should remove that final line-continuation backslash in the commands.

Mannuel25 avatar Sep 18 '22 19:09 Mannuel25

@Mannuel25 did you look into the 1.2-maint branch (not: master)?

ThomasWaldmann avatar Sep 18 '22 21:09 ThomasWaldmann

borg prune                          \
    --list                          \
    --prefix '{hostname}-'          \
    --show-rc                       \
    --keep-daily    7               \
    --keep-weekly   4               \
    --keep-monthly  6               \

The last backslash there is not needed, because the command is not really continued on the next line (which is empty).

One change for prune, once for create.

ThomasWaldmann avatar Sep 18 '22 21:09 ThomasWaldmann

@Mannuel25 did you look into the 1.2-maint branch (not: master)?

Oh, I didn't. I've seen it now. Thanks

Mannuel25 avatar Sep 18 '22 21:09 Mannuel25

borg prune                          \
    --list                          \
    --prefix '{hostname}-'          \
    --show-rc                       \
    --keep-daily    7               \
    --keep-weekly   4               \
    --keep-monthly  6               \

The last backslash there is not needed, because the command is not really continued on the next line (which is empty).

One change for prune, once for create.

Got that. Thank you.

Mannuel25 avatar Sep 18 '22 21:09 Mannuel25

Is this still Open for contribution?

i-m-karanagarwal avatar Oct 03 '22 13:10 i-m-karanagarwal

@i-m-karanagarwal sure, it is still open, just make a PR!

ThomasWaldmann avatar Oct 03 '22 14:10 ThomasWaldmann

@i-m-karanagarwal sure, it is still open, just make a PR!

Hi @ThomasWaldmann , I thought I fixed this already

Mannuel25 avatar Oct 03 '22 14:10 Mannuel25

@Mannuel25 oops, yes, correct: https://github.com/borgbackup/borg/pull/7039

ThomasWaldmann avatar Oct 03 '22 17:10 ThomasWaldmann

In master, a similar fix was done, so this is solved.

ThomasWaldmann avatar Oct 03 '22 17:10 ThomasWaldmann