borg icon indicating copy to clipboard operation
borg copied to clipboard

ctrl-c must not kill important subprocesses, fixes #6912

Open ThomasWaldmann opened this issue 3 years ago • 3 comments

ThomasWaldmann avatar Aug 06 '22 10:08 ThomasWaldmann

Did a quick test running a borg create against a ssh: remote repo: it behaves now as expected:

  • no "broken pipe"
  • successfully writes checkpoint

ThomasWaldmann avatar Aug 06 '22 10:08 ThomasWaldmann

There are some other places with subprocesses:

  • --content-from-command
  • --paths-from-command
  • import-tar / export-tar (for the (de)compression filter process)

Guess we do not want these killed by ctrl-c either. borg needs to determine when it wants to finish.

ThomasWaldmann avatar Aug 06 '22 10:08 ThomasWaldmann

Codecov Report

Merging #6944 (7a31978) into 1.2-maint (fa8d8ec) will increase coverage by 0.00%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           1.2-maint    #6944   +/-   ##
==========================================
  Coverage      82.90%   82.91%           
==========================================
  Files             38       38           
  Lines          10579    10581    +2     
  Branches        2210     2210           
==========================================
+ Hits            8771     8773    +2     
- Misses          1285     1286    +1     
+ Partials         523      522    -1     
Impacted Files Coverage Δ
src/borg/helpers/process.py 65.30% <50.00%> (-0.16%) :arrow_down:
src/borg/archiver.py 80.20% <100.00%> (+0.09%) :arrow_up:
src/borg/remote.py 79.52% <100.00%> (-0.33%) :arrow_down:
src/borg/platform/base.py 80.15% <0.00%> (-1.59%) :arrow_down:
src/borg/repository.py 83.57% <0.00%> (-0.19%) :arrow_down:
src/borg/helpers/parseformat.py 89.88% <0.00%> (+0.16%) :arrow_up:
src/borg/archive.py 82.32% <0.00%> (+0.24%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov-commenter avatar Aug 06 '22 10:08 codecov-commenter