borg icon indicating copy to clipboard operation
borg copied to clipboard

Initial functional tests for diff --format (Issue #4634)

Open palao opened this issue 4 years ago • 7 comments

Could you please tell me if this test is in the right direction and what else would you like to see there?

palao avatar Jul 31 '21 15:07 palao

Do I close this pull request and make a new one when ready, or do we use this one?

palao avatar Aug 05 '21 15:08 palao

@palao did you see my feedback?

you can just continue within this pull request, just do some fixup commits.

also, considering age of this PR, maybe updating your local master branch and then doing a git rebase -i master within this PR branch would be a good idea.

ThomasWaldmann avatar Jan 16 '22 19:01 ThomasWaldmann

@ThomasWaldmann thank you for the reminder. I'll do that.

palao avatar Jan 21 '22 15:01 palao

Considering this PR is a bit older already, maybe you could:

  • update your local master branch
  • switch to your PR branch
  • git rebase -i master # ... and carefully resolve conflicts, if any
  • git push -f # update PR

We recently had some fixes for testing, so CI will work better after that.

ThomasWaldmann avatar Jan 21 '22 19:01 ThomasWaldmann

As the code is now, the tests pass. The code is asking for a refactor, though. I'm aware of that. The implementation is too simple and ugly. But before refactoring, I think one needs to consider what are the real needs: what are the necessary placeholders? That will dictate how to modify the tests, and how to implement the functionality in a better way (ItemDiffFormatter?)

palao avatar Feb 03 '22 17:02 palao

@derekkaup what did you want to tell us here?

ThomasWaldmann avatar Aug 09 '22 22:08 ThomasWaldmann

FWIW and just to repeat, or to make more clear my intentions: this PR's motivation is to get feedback to be able to follow a direction. The PR itself, as it is, is incomplete.

palao avatar Aug 10 '22 10:08 palao

#7534

RF-Tar-Railt avatar Apr 27 '23 17:04 RF-Tar-Railt

@RF-Tar-Railt can you review / check this?

ThomasWaldmann avatar Jun 11 '23 20:06 ThomasWaldmann

@RF-Tar-Railt can you review / check this?

format part can be ignored, but the part of test can check

RF-Tar-Railt avatar Jun 11 '23 20:06 RF-Tar-Railt