Initial functional tests for diff --format (Issue #4634)
Could you please tell me if this test is in the right direction and what else would you like to see there?
Do I close this pull request and make a new one when ready, or do we use this one?
@palao did you see my feedback?
you can just continue within this pull request, just do some fixup commits.
also, considering age of this PR, maybe updating your local master branch and then doing a git rebase -i master within this PR branch would be a good idea.
@ThomasWaldmann thank you for the reminder. I'll do that.
Considering this PR is a bit older already, maybe you could:
- update your local master branch
- switch to your PR branch
git rebase -i master# ... and carefully resolve conflicts, if anygit push -f# update PR
We recently had some fixes for testing, so CI will work better after that.
As the code is now, the tests pass. The code is asking for a refactor, though. I'm aware of that. The implementation is too simple and ugly.
But before refactoring, I think one needs to consider what are the real needs: what are the necessary placeholders? That will dictate how to modify the tests, and how to implement the functionality in a better way (ItemDiffFormatter?)
@derekkaup what did you want to tell us here?
FWIW and just to repeat, or to make more clear my intentions: this PR's motivation is to get feedback to be able to follow a direction. The PR itself, as it is, is incomplete.
#7534
@RF-Tar-Railt can you review / check this?
@RF-Tar-Railt can you review / check this?
format part can be ignored, but the part of test can check