borg icon indicating copy to clipboard operation
borg copied to clipboard

get rid of master/slave terminology

Open ThomasWaldmann opened this issue 5 years ago • 12 comments

master/slave was used a lot in the code that deals with hardlinks:

when we archive multiple hardlinks pointing to same inode (file contents), this happens:

  • the first encountered hardlink is treated like any regular file: its file contents are chunked, chunks written to repo, file metadata and chunkid_list is written to the archived item.
  • all afterwards discovered hardlinks referring to same inode also create a regular file item, but its source attribute points back to the name of the first encountered hardlink. these items do not have a chunkid_list and thus no own content.

so we need new terminology for this now, please suggest.

ThomasWaldmann avatar Jul 07 '20 21:07 ThomasWaldmann

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Sep 13 '24 16:09 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: df9e634c4f3f09860ddc26c0e48a80ad4245e784

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 13 '24 16:09 changeset-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33281/ on branch gh-pages at 2024-12-10 14:51 UTC

github-actions[bot] avatar Sep 13 '24 16:09 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.28%. Comparing base (41f5df1) to head (df9e634). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #33281       +/-   ##
============================================
- Coverage    75.79%   60.28%   -15.51%     
============================================
  Files          511     2680     +2169     
  Lines        22132    65863    +43731     
  Branches      5394    14588     +9194     
============================================
+ Hits         16775    39708    +22933     
- Misses        4709    23362    +18653     
- Partials       648     2793     +2145     
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 13 '24 16:09 codecov[bot]