borg icon indicating copy to clipboard operation
borg copied to clipboard

review IntegrityErrors, especially when they kill

Open ThomasWaldmann opened this issue 8 years ago • 1 comments

at some places (borg check --repair) we kill repository objects when we encounter IntegrityErrors on them.

for many cases this is the right thing to do - if an object is corrupt, it is not useful any more.

but when reading the LoggedIO code, i got the impression that some of the IEs raised there could be due to:

  • corrupt repository index just pointing at some bad segment/offset where no object starts
  • corrupt repository index pointing at a valid object, but for a different ID (maybe extremely unlikely, but who knows?)
  • too large objects, https://github.com/borgbackup/borg/blob/1.1.0b4/src/borg/repository.py#L1175
  • other cases?

https://www.bountysource.com/issues/44509028-review-integrityerrors-especially-when-they-kill

ThomasWaldmann avatar Apr 25 '17 14:04 ThomasWaldmann

some work (mostly adding comments) was done in #2691 (but was not merged).

ThomasWaldmann avatar Jul 02 '18 15:07 ThomasWaldmann