fakerpress icon indicating copy to clipboard operation
fakerpress copied to clipboard

call_user_func_array calls need more array_values updates

Open sc0ttkclark opened this issue 2 years ago • 1 comments

There are still some stragglers that use call_user_func_array and pass in arrays that have string keys. Those get interpreted as PHP named arguments just like what was reported at https://github.com/bordoni/fakerpress/issues/147

That one case was fixed but there are likely others, especially ones in this kind of context with min/max or width/height.

This may take manual review on your side to ensure that they are caught as I don't want to just PR the changes with array_values() everywhere it may not be needed.

sc0ttkclark avatar Sep 07 '23 22:09 sc0ttkclark

Thank you @sc0ttkclark I finally should have some extra time this upcoming week, I will definitely make sure this is included.

bordoni avatar Sep 08 '23 02:09 bordoni