rmview icon indicating copy to clipboard operation
rmview copied to clipboard

Feature request: Customize binary location

Open axelson opened this issue 3 years ago • 1 comments

Hi, first off, thanks for this software, it's great and very fast! :)

I'd like to make a request to use a non-default binary location on the remarkable tablet. Currently for the RM2 the binary path appears to be hardcoded to /home/root/rM-vnc-server-standalone. I'd like to customize that to /home/root/bin/rM-vnc-server-standalone as part of an effort to keep my /home/root directory clean and uncluttered.

I see two main options for this:

  1. Add a binary_path option to the host computer's ~/.config/rmview.json file
  2. Add /home/root/bin/rM-vnc-server-standalone as a path for rmview to look for the binary, and use it if found

If either of those approaches (or a third one) appeals to you, then I could look into preparing a PR.

axelson avatar Jan 10 '21 21:01 axelson

Hi! This is definitely something I wanted to add at some point. I think option 1 is the best. I would go with something like a vnc_server_path key for the setting. This is because if in the future we want to call more than just one binary we don't have ambiguous setting keys. If you could prepare a PR I'd be happy to review and merge!

bordaigorl avatar Jan 10 '21 21:01 bordaigorl