Oliver Borchert comments

Results 115 comments of


                                            Oliver Borchert

idea: Include changes to outputs in pull request comments

Good catch, I think that would be a great addition to this action! Unfortunately, it is currently unsupported. I'd be happy to review a PR for this, it would take...

Error: Cannot read properties of undefined (reading 'head')

Is the workflow called from a `pull_request` event? I think this would cause the error (which should probably be improved...).

Error: Cannot read properties of undefined (reading 'head')

I see! Your workflow requires the trigger ``` on: pull_request: ``` as, otherwise, the action does not know which PR to post a comment to. In a `push` event, the...

Error: Cannot read properties of undefined (reading 'head')

> Now do we skip posting when we have a workflow with both: Yes, exactly. You'd need to add `if: github.event_name == 'pull_request'` to the workflow step which uploads the...

Lines in mult-line properties starting with whitespace and dash classified as deletions

Uh, interesting case, thanks a lot for surfacing! I'll think about how to fix this, I hadn't dealt with plain YAML files in Terraform yet :eyes:

Lines in mult-line properties starting with whitespace and dash classified as deletions

Yup, all boils down to the same issue! It should be possible to reverse-engineer this, the relevant information should be available :eyes:

idea: Support for adding to the summary page of a workflow run

This sounds very reasonable! And I think it can be nicely combined with the request in #12 :eyes:

idea: add support for warnings

I think this would be a great addition! I personally haven't worked with TF checks yet but this seems very much in scope of this action :) > I would...

[python-package] Fitting on Polars Dataframe fails due to missing setter for fetures_names_in_

I'll be investigating this week 😅

[python-package] Fitting on Polars Dataframe fails due to missing setter for fetures_names_in_

Sorry, I obviously did not get to this yet 😅 > I'd be happy to help resolving it if needed Thanks for the offer @ErikBavenstrand! Given that LightGBM does not...