pydis icon indicating copy to clipboard operation
pydis copied to clipboard

Importance of async?

Open mahmoud opened this issue 5 years ago • 1 comments

Excellent work! Just wanted to mention, if straight-line performance is the goal, it may be worth testing a non-async version of the code. Most operations are going to be gated on the dictionary backing the application, so unless idle connections are part of the benchmark, the async component might be introducing more overhead than strictly necessary. What do you think?

mahmoud avatar Mar 06 '19 05:03 mahmoud

Hmm, I could not find a benchmark back then that compares uvloop backed asyncio protocol to non-async versions, though the "traditional" way comes with its own implementation complexity too so I wouldn't consider it unless there is a significant performance gain to be made.

Let me know if you find any such benchmarks and I am happy to try alternative approaches! =)

boramalper avatar Nov 15 '20 17:11 boramalper