Bora Berke Sahin

Results 26 comments of Bora Berke Sahin

> I feel like an error might makes more sense 🤔 I don't personally use dbt that much, but I guess `steps_override, schema_override, threads_override` could significantly change the behavior somehow....

@Lee-W, I will double-check if rerun uses the overrides, i.e. runs exactly the way the first job run, then add the warning or error accordingly! Thanks for your comments!

@Lee-W, I have tested and here how it works: When first run already uses `steps_override, schema_override, additional_run_config` and the first run is failed, rerunning it will use the same config...

@Lee-W, thanks for the review! Fixed upon your latest comments as well :)

Hey @josh-fell, would greatly appreciate your thoughts and suggestions on this!

Hi @dirrao, did you have a chance to look at this PR again? Would appreciate your comments!

As an additional question or note: I am not sure if I should modify the docstring of the following operators: - BaseBranchOperator - BranchPythonOperator - BranchPythonVirtualenvOperator - BranchExternalPythonOperator - BranchDateTimeOperator...

Hi @josh-fell, thank you for your feedback! > I'm trying to understand the what happens if a user sets `retry_from_failure=True` on the operator and provides either `steps_override`, `schema_override`, or `additional_run_config`...