Boquan Fang
Boquan Fang
### Resolved issues: Resolves the second requirement #4684. This PR is also a alternative for PR#4734. ### Description of changes: * Change the file name of `buildspec_asan.yml` to `buildspec_sanitizer.yml`. *...
### Problem: 1. `-Wcast-qual` is not enabled with `awslc`. 2. The `S2N_LIBCRYPTO` environmental variable needs to be set for that `-Wcast-qual` to be enabled. https://github.com/aws/s2n-tls/blob/45bf1d4bc314cf8b18b8632e8be25180e45f121f/CMakeLists.txt#L212-L215 ### Requirements / Acceptance Criteria:...
### Resolved issues: Solving issue #3062 ### Description of changes: Change most of memcmp usages to s2n_constant_time_equals. There are two parts that weren't change, which are in s2n_cipher_suits.c (line 1110)...
### Resolved issues: Resolve issue #4710 ### Description of changes: * Remove the condition which only add -Wcast-qual back for non AWS-lc Libcrypto. ### Call-outs: * Waiting for `awslc` update...
### Resolved issues: Partially solve #4005 ### Description of changes: * Add `--track-fds=yes` options to `VALGRIND_DEFAULT` option. * Add `s2n_open_fds_test.py` script to test for any unexpected open file descriptors at...
### Resolved issues: Partially solve https://github.com/aws/s2n-tls/issues/4005 ### Description of changes: * Clean up all of opened `/dev/urandom`. ### Call-outs: * See [PR#4833](https://github.com/aws/s2n-tls/pull/4833) and [PR#4834](https://github.com/aws/s2n-tls/pull/4834) for fixes of other open fds....
### Resolved issues: Partially solve #4005. Detected opened AF_INET sockets in `s2n_self_talk_ktls_test.c`. ### Description of changes: * Close all AF_INET in `s2n_new_inet_socket_pair`. The child process exits without close all AF_INET...
### Problem: The current way of setting `S2N_LIBCRYPTO` environment variable is through passing it in `CMAKE_PREFIX_PATH`, and then use it in `CMakeLists.txt`. We want to set `S2N_LIBCRYPTO` in a more...
### Resolved issues: This PR makes a more generic buildspec_analyzer job. This job will contain both * valgrind unit tests * sanitizer (ASAN, UBSAN) unit tests After this PR is...