jenkins-templating-engine icon indicating copy to clipboard operation
jenkins-templating-engine copied to clipboard

New repositories use "main" as default branch name

Open etho201 opened this issue 4 years ago • 1 comments

PR Details

New repositories use main as default branch name.

Description

I ran into issues going through the SDP learning lab because I assumed it was safe to keep my branch defined as master. Once I inspected my repository I noticed that GitHub now uses main as the default branch name for new repositories.

More info can be found here: https://github.com/github/renaming

How Has This Been Tested

I did not test this change, but can confirm that new repositories use main by default and this may stump new users who are following the SDP learning lab.

Types of Changes

  • [ ] Added Unit Testing
  • [ ] Docs change / refactoring / dependency upgrade
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] I have added the appropriate label for this PR
  • [ ] If necessary, I have updated the documentation accordingly.
  • [ ] All new and existing tests passed.

etho201 avatar Nov 05 '20 18:11 etho201

@etho201 Thanks for bringing this to our attention. Since you mentioned the 'master' vs 'main', I suspect a change is needed in the documentation for the learning labs. If you don't mind, where in the learning labs did you encounter the name issue?

Also,I suggest that you run some testing before submitting a PR. You updated the branch name in a stub on unit tests, but I suspect those tests still worked regardless of the 'master' branch name. Thanks again

cokieffebah avatar Nov 06 '20 15:11 cokieffebah