will_paginate-bootstrap icon indicating copy to clipboard operation
will_paginate-bootstrap copied to clipboard

Ensure pagination list is wrapped in a div.

Open thomasbiddle opened this issue 11 years ago • 3 comments
trafficstars

I'm actually not sure how this gem worked prior - but Bootstrap specs require that the pagination list is wrapped in a div, which has the correct class applied to it.

Gem wasn't working for me without this - simply showed up as an unstyled list.

thomasbiddle avatar Oct 30 '14 17:10 thomasbiddle

I just came across this project and am planning on using it. Thanks for the work!

@thomasbiddle Just wanted to comment that the pagination was wrapped in a div for Bootstrap 2, but with Bootstrap 3, the examples show it wrapped in a nav tag, and that's no longer an essential part of the component itself. The pagination class is now set on the ul instead of the containing div.

I think I'm going to wrap my usages of this in a nav tag, but as much as I think it would be nice to have that part of the renderer, I think it should maybe be left up to the individual user if they want to put the pagination ul inside any other container (nav or div or whatever)? What do you all think?

drueck avatar Nov 13 '14 21:11 drueck

@drueck That's a good point! Hadn't realized Bootstrap 3 changed that.

Is the class set on the ul tag, or the nav tag then? When I was using this as it was originally built it was setting the class on ul I believe, and wasn't working. If B3 is expecting it to be set on nav then there still would need to be a change otherwise you would get an unformatted list, no?

thomasbiddle avatar Nov 14 '14 16:11 thomasbiddle

The class is set on the ul tag in Bootstrap 3. See the current docs for pagination here: http://getbootstrap.com/components/#pagination

drueck avatar Nov 14 '14 21:11 drueck