bootstrap_form icon indicating copy to clipboard operation
bootstrap_form copied to clipboard

Published 20 hours ago • verified publisher icon bootstrap-ruby

Check how Danger determines whether tests have been added.

Open lcreid opened this issue 6 years ago • 1 comments
trafficstars

PR #513 added a test in a new file, but Danger reported that no tests had been added. Make sure Danger correctly identifies if tests have been added.

lcreid avatar Jan 31 '19 15:01 lcreid

Without having tested: It appears that Danger's modified files are files that were existing and have changed. There is also an added_files method, that would presumably return something for added files. The Dangerfile currently only checks modified files. Ideally we'd check added_files too, but it's not something that's going to happen very often.

lcreid avatar Jan 31 '19 17:01 lcreid