bootstrap_form icon indicating copy to clipboard operation
bootstrap_form copied to clipboard

Refactor to remove the separate Helpers::Bootstrap module?

Open GBH opened this issue 7 years ago • 2 comments
trafficstars

Why was it separated out? I was looking where form.submit was because I assumed it also was victim of submit_without_bootstrap. It was spared because it lived in a separate module for some reason.

I think this should be merged back into form_builder.rb shortly after main builder class is clean and nice to work with.

GBH avatar Jan 18 '18 05:01 GBH

My guess is that it was an attempt to reduce the size of form_builder.rb, which is a huge class that is begging to be refactored. If so, the intention was good, but using modules doesn't really solve the underlying issue; it just spreads the code around.

While I agree that the module probably shouldn't have been separated in the first place, I don't see a compelling reason to merge it back in right now. I'd rather get v4 out the door first, and then consider the best way to organize the code into smaller files, if that's even possible.

mattbrictson avatar Jan 21 '18 18:01 mattbrictson

FWIW: I stumbled across the commit that appears to have introduced this module: ae08c5b1.

lcreid avatar Feb 08 '18 15:02 lcreid