ret-sync icon indicating copy to clipboard operation
ret-sync copied to clipboard
verified publisher icon bootleg

ghidra addHighlightBrace has been renamed to addBraceHighlight in master

Open alexmaloteaux opened this issue 4 years ago • 2 comments

not really an issue atm but more a warning, addHighlightBrace in ghidra master / 10.2 has been rename to addBracehighlight here : https://github.com/NationalSecurityAgency/ghidra/blob/bed44bd55dc88c7c6fab5f158cdb4b9daa087519/Ghidra/Features/Decompiler/src/main/java/ghidra/app/decompiler/component/ClangHighlightController.java#L610

compilation of the plugin against master fails here : https://github.com/bootleg/ret-sync/blob/7602ddd8ebc77f5f14d958e26843944861331b66/ext_ghidra/src/main/java/retsync/LocalColorizerService.java#L302

alexmaloteaux avatar Dec 07 '21 03:12 alexmaloteaux

Hello Alexandre,

Big thank you for the heads-up here.

The highlighting code in the Ghidra plugin is really shaky right now.

I need to dig more into it but a stable highlighter service would be great, it was missing so far with many classes not exposed. https://github.com/NationalSecurityAgency/ghidra/commit/02ef6109e27d2bf930ab40ab66fa2538ee15afe9

I'll keep the issue open until the 10.2 is released and I update ret-sync code accordingly.

Thanks.

bootleg avatar Dec 07 '21 23:12 bootleg

Hi, this is preventing a build of ret-sync with gradle-7.6, jdk19, for ghidra 10.2.2 .

Ideas for a workaround ? [edit] - there is, #96

fenugrec avatar Dec 10 '22 01:12 fenugrec