Json-Eclipse-Plugin
Json-Eclipse-Plugin copied to clipboard
boothen
JSON Editor plug-in renders JSON files unreadable
This is an issue that affects many Eclipse plug-ins, it has gotten worse with the years and become especially acute with Photon (affects about 90% of the plug-ins I use). Eclipse advertises plug-ins from the Marketplace whenever the user opens a particular file type, say JSON, HTML, PHP, SQL, etc. However, when these plug-ins are installed those files become unreadable. I reported this issue against the Workbench itself, but folks there insist that this issue must be reported to the plug-in developers.
This JSON plug-in is one of the many plug-ins affected. Here is a screenshot of a JSON file right after installing the plug-in:
I have a hard time believing so many developers purposely ship plug-ins that do not function out-of-the- box. I am therefore reporting this issue here to understand what is the sentiment this side of the development stack.
Thank you.
Thanks for the report, Luis. I see that the default theme is hard to read on a dark background. Is that the problem? So you would want a different default theme? If you like, you can configure the color through the eclipse properties dialogue.
@msteiger I use different programmes that provide plug-ins mechanisms, and none has this sort of issues like Eclipse. Take gEdit for instance, plug-ins integrate automatically with any kind of DE theme in place. What is most strange with Eclipse is that it supersedes any DE or system theme with its own. So why can't plug-ins seamlessly integrate? If the current theme is set by Eclipse itself, what is prevent plug-ins from adopting it?
Thank you.
So you're suggesting to automatically adjust the colors to work with the selected eclipse color theme? Sounds interesting and it's certainly a challenge.
Depending on the background color, you could pre-define a list of colors that "work well" and provide them through the eclipse UI to the plugins so they can use them for their purpose. This would be mainly work for the eclipse main project and I support it if you will propose something like that.
@msteiger Just to make it clear: as a plug-in developer you are not able to provide an agnostic text colour scheme. You must randomly select one of the themes provided by Eclipse and target that, leaving it to users to tweak colours if it does not blend. Am I correct?
If this is the case then something must definitely change with Eclipse itself. I will keep you posted if this evolved into a more thorough bug report or feature request.
And thank you for your support.
More or less. Actually the plugin is not linked to the eclipse color theme at all, since it doesn't really provide anything useful. The JSON plugin just defines colors that work well on a white background by itself.
I would suggest an integration into the eclipse theme plugin and most importantly a method that provides a list of 5-10 colors from the currently selected theme (without any assignment to a meaning/use case).
The plugin could then assign those color to the different internal functionalities without the need to worry about the colors themselves. And all the other plugins could do the same, and thus ensure that it always works OK for the selected theme/background.
Why did you delete your comment @mboso?
If the theme plugin was part of the default eclipse packages, your suggestion would be the most logical thing to do. Still, it could make sense to check if it is present and use the values from there instead. A bit more effort, but maybe worth it ..
This was already started here: https://github.com/eclipse-color-theme/eclipse-color-theme/pull/254
I think it's a great starting point, but it looks like the theme plugin isn't really active anymore, so it might not get merged at all :-(