boot-cljs icon indicating copy to clipboard operation
boot-cljs copied to clipboard

ClojureScript expects populated java.class.path on Java 9 and newer in order to use externs

Open svdm opened this issue 5 years ago • 0 comments

This is essentially the issue that was reported on clojurescript itself as CLJS-2529: https://clojure.atlassian.net/projects/CLJS/issues/CLJS-2529 And subsequently fixed in clojure/clojurescript@8670cc40cf09f90f1d36cb4bf0a2c68713fb1d68

However, that fix expects java.class.path to contain all relevant resources including extern JS files (when on Java 9+). That's not true for boot, where it only contains the boot executable. As a result externs remain ignored on Java 9+ when compiling as part of a boot build.

I'm not entirely sure how to best fix this. I've experimented with a hack that comes down to doing (System/setProperty "java.class.path" (get-env :fake-class-path)) before running the cljs task. This appears to work (externs are used etc) but I'm not sure what side effects it might have on other consumers of that classpath property. If this step was performed inside boot-cljs its scope could be restricted to the cljs build more easily.

svdm avatar Jan 03 '20 14:01 svdm