url icon indicating copy to clipboard operation
url copied to clipboard

feat: decode free functions

Open alandefreitas opened this issue 3 months ago • 7 comments

fix #947

alandefreitas avatar Nov 12 '25 22:11 alandefreitas

An automated preview of the documentation is available at https://952.url.prtest2.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-11-12 22:39:34 UTC

cppalliance-bot avatar Nov 12 '25 22:11 cppalliance-bot

you might have pulled the trigger a little too quickly on this. look at how beast2 is using percent-decoding:

https://github.com/cppalliance/beast2/blob/daf37da49b4fdf3fcc66d4d6e920205717c86bd2/src/server/detail/any_router.cpp#L42

(I plan on refactoring to StringToken to re-use strings)

vinniefalco avatar Nov 12 '25 22:11 vinniefalco

I plan on refactoring to StringToken to re-use strings

Don't we already have a string token for that?

https://952.url.prtest2.cppalliance.org/url/reference/boost/urls/string_token/assign_to.html

alandefreitas avatar Nov 12 '25 22:11 alandefreitas

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 99.21%. Comparing base (bbe9700) to head (24937d3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #952   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files          159      160    +1     
  Lines         8684     8708   +24     
========================================
+ Hits          8616     8640   +24     
  Misses          68       68           
Files with missing lines Coverage Δ
include/boost/url/impl/decode.hpp 100.00% <100.00%> (ø)
src/detail/decode.cpp 100.00% <ø> (ø)
src/detail/normalize.cpp 99.30% <ø> (ø)
src/detail/segments_iter_impl.cpp 99.19% <ø> (ø)
src/pct_string_view.cpp 100.00% <ø> (ø)
src/url_base.cpp 99.66% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbe9700...24937d3. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 12 '25 22:11 codecov[bot]

Don't we already have a string token for that?

I mean that I will change my code to use a StringToken api

vinniefalco avatar Nov 12 '25 23:11 vinniefalco