url icon indicating copy to clipboard operation
url copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

review size limits

Open vinniefalco opened this issue 3 years ago • 3 comments

Without the table we could use a larger bit width for off_t. And we should review every function to make sure it respects the size limits. Te refactoring of the top level rfc rules may have invalidated existing checks for limits.

vinniefalco avatar Jul 28 '22 15:07 vinniefalco

I removed checks for max_size

vinniefalco avatar Sep 03 '22 20:09 vinniefalco

We are just working with std::size_t now and off_t doesn't exist anymore. What's the state of this issue? Does it still make sense?

alandefreitas avatar Oct 13 '22 16:10 alandefreitas

I'm pretty sure there are a few loose ends where we don't correctly check for overflow when performing unsigned arithmetic. I tried to get edit_segments and edit_params right, maybe you want to look at them and see if they are correct and sufficiently tested?

vinniefalco avatar Oct 13 '22 18:10 vinniefalco