ublas icon indicating copy to clipboard operation
ublas copied to clipboard

Fixing iteration-type of for-loop.

Open amitsingh19975 opened this issue 3 years ago • 3 comments

The current loops rely on auto deduction or integer suffix for the type that may not be a correct iteration type and may produce conversion warnings all over places. Therefore, I propose to remove auto from the loops and use appropriate and explicit types or use explicit types to initialize the variable. In a long run, it would produce a bug-free code, and it would remove all warnings produced by compilers.

From

for(auto d = 0u; d < t.size(); ++d)
{
...
}

To

for(auto d = size_type{0}; d < t.size(); ++d)
{
...
}

amitsingh19975 avatar Feb 11 '22 14:02 amitsingh19975

Can I take up this issue if no one is working upon it. Kindly assign it to me

Neel-Shah-29 avatar Feb 11 '22 15:02 Neel-Shah-29

Can I take up this issue if no one is working upon it. Kindly assign it to me

I'm waiting for others' views on this. Therefore, wait for a few days. So, I request you to read the tensor's codebase and try to find bugs or enhancements that you think would improve the tensor. Finding bugs is also a way to contribute.

amitsingh19975 avatar Feb 11 '22 16:02 amitsingh19975

Since 20 days, if no one is putting input over this issue , Can i take up this issue ?

Neel-Shah-29 avatar Feb 19 '22 08:02 Neel-Shah-29