ublas icon indicating copy to clipboard operation
ublas copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

Fix deprecated copy warnings

Open apolukhin opened this issue 3 years ago • 8 comments

All the implicit special member functions made explicit in this PR. It fixes the compilation and test runs with ./b2 libs/numeric/ublas/test/ cxxstd=17 "cxxflags=-Werror=deprecated-copy" toolset=clang-13 -j4

apolukhin avatar Jan 17 '22 13:01 apolukhin

If I'm correct, it won't be a problem if we follow the rule of six. This warning arises when you give the copy assignment constructor without providing the default copy constructor. I assume the ublas code base follows the rule of six. If it does not, we have to fix that.

Godbolt

amitsingh19975 avatar Feb 07 '22 09:02 amitsingh19975

Yes, you are right. This PR adds the missing functions for C++11

apolukhin avatar Feb 07 '22 09:02 apolukhin

Yes, you are right. This PR adds the missing functions for C++11

Ok.

amitsingh19975 avatar Feb 07 '22 10:02 amitsingh19975

Gentle reminder

apolukhin avatar May 19 '22 09:05 apolukhin

@bassoy gentle reminder

apolukhin avatar Jun 05 '22 11:06 apolukhin

@amitsingh19975 could you please somehow speedup the PR review process?

apolukhin avatar Sep 02 '22 16:09 apolukhin

It's up to others. I cannot do anything. I would recommend contacting @bassoy via email or someone who has much more power than me.

amitsingh19975 avatar Sep 02 '22 17:09 amitsingh19975

@bassoy Please merge

apolukhin avatar Feb 14 '24 10:02 apolukhin