pfr icon indicating copy to clipboard operation
pfr copied to clipboard

View manipulator and is_reflectable trait

Open denzor200 opened this issue 3 years ago • 2 comments

https://github.com/boostorg/pfr/issues/100

denzor200 avatar Sep 09 '22 19:09 denzor200

I don't want to devalue your work, after all thanks for at least trying to work on this. Probably you misunderstood me, it seems that is_reflectable is just a placeholder? It actually does nothing by default? Maybe I forgot to show you that there is already in the library an almost working trait https://github.com/boostorg/pfr/blob/b7d839b851dc37506fd6a5a91ab5404e44d6a012/include/boost/pfr/detail/fields_count.hpp#L77-L92 your best bet is to fix some of it's blind spots and it solves the exact problem. Or you have tried to fix it and came to conclusion that it's not possible?

Also, a general rule: the less code is for a review the faster your PR is getting reviewed and more chances for it to be merged in a timely manner.

Kojoley avatar Sep 09 '22 20:09 Kojoley

Probably you misunderstood me, it seems that is_reflectable is just a placeholder? It actually does nothing by default?

I do understand you about your issue automatic is_reflectable, this PR won't make to resolve issue impossible, issue will be resolved in the future version of PFR.

denzor200 avatar Sep 12 '22 06:09 denzor200

Not actual. Actual PR here: https://github.com/boostorg/pfr/pull/111

denzor200 avatar Dec 16 '22 16:12 denzor200