Fix #700

This implementation makes these choices:

Nulls are replaced when creating intermediaries.
When creating intermediaries segments are always treated as object keys, (that is only objects are created as intermediaries).
Arrays are extended by 1 element at most.

Jun 03 '22 12:06 grisumbras

Codecov Report

Merging #713 (36cb433) into develop (c650832) will increase coverage by 0.13%. The diff coverage is 100.00%.

:exclamation: Current head 36cb433 differs from pull request most recent head a210032. Consider uploading reports for the commit a210032 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #713      +/-   ##
===========================================
+ Coverage    99.00%   99.13%   +0.13%     
===========================================
  Files           70       69       -1     
  Lines         6802     6613     -189     
===========================================
- Hits          6734     6556     -178     
+ Misses          68       57      -11

Impacted Files	Coverage Δ
include/boost/json/value.hpp	`98.91% <ø> (-0.05%)`	:arrow_down:
include/boost/json/value_ref.hpp	`100.00% <ø> (ø)`
include/boost/json/impl/pointer.ipp	`100.00% <100.00%> (ø)`
include/boost/json/array.hpp	`100.00% <0.00%> (ø)`
include/boost/json/object.hpp	`100.00% <0.00%> (ø)`
include/boost/json/string.hpp	`100.00% <0.00%> (ø)`
include/boost/json/value_to.hpp	`100.00% <0.00%> (ø)`
include/boost/json/impl/array.hpp	`100.00% <0.00%> (ø)`
include/boost/json/impl/array.ipp	`100.00% <0.00%> (ø)`
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c650832...a210032. Read the comment docs.

Jun 03 '22 12:06 codecov[bot]

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html

Jun 03 '22 15:06 cppalliance-bot

Why did performance change

Jun 08 '22 22:06 vinniefalco

Mystery to me too

Jun 09 '22 09:06 grisumbras

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html

Jun 21 '22 20:06 cppalliance-bot

An automated preview of the documentation is available at https://713.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

Jun 21 '22 21:06 cppalliance-bot

An automated preview of the documentation is available at https://713.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

Jun 21 '22 21:06 cppalliance-bot

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html

Jun 21 '22 22:06 cppalliance-bot

An automated preview of the documentation is available at https://713.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

Jul 10 '22 18:07 cppalliance-bot

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html

Jul 10 '22 19:07 cppalliance-bot

An automated preview of the documentation is available at https://713.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

Aug 03 '22 20:08 cppalliance-bot

An automated preview of the documentation is available at https://713.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

Aug 03 '22 20:08 cppalliance-bot

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html

Aug 03 '22 21:08 cppalliance-bot

An automated preview of the documentation is available at https://713.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

Aug 04 '22 07:08 cppalliance-bot

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html

Aug 04 '22 09:08 cppalliance-bot

Kind of a long section name though

Aug 13 '22 14:08 vinniefalco

If it doesn't already say so, the javadoc / exposition for value_ref should explain that objects of that type should only be declared as function parameters. Never as class members, local variables, or objects with static storage duration.

Aug 13 '22 14:08 vinniefalco

The decision to only create objects along the way seems unintuitive and controversial. What do other implementations of JSON Pointer do? What is the rationale for this?

Aug 13 '22 14:08 vinniefalco

This PR is not ready... needs work :)

Aug 13 '22 15:08 vinniefalco

Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/713/pullrequest.html