json icon indicating copy to clipboard operation
json copied to clipboard

value_to, value_from precedence javadoc

Open vinniefalco opened this issue 4 years ago • 3 comments

value_to is unclear about the precedence of the three listed options (constructor, library provided conversion or tag_invoke) if multiple are present provided this is actually possible. The same is true for value_from.

vinniefalco avatar Sep 22 '20 17:09 vinniefalco

https://develop.json.cpp.al/json/usage/conversion.html

The library provided overloads have no special prioritization over those provided by the user, so care should be taken to avoid writing ambiguous declarations:

sdkrystian avatar Sep 25 '20 17:09 sdkrystian

We are removing the constructor, and the javadocs should probably repeat the warning

vinniefalco avatar Sep 25 '20 17:09 vinniefalco

Sounds good

sdkrystian avatar Sep 30 '20 18:09 sdkrystian

The order is now documented (as of release 1.81).

grisumbras avatar Mar 02 '23 13:03 grisumbras