Add rank spanning branchings routine for possible inclusion in library.

[mbradle]

Hello,

I am opening a new version of this pull request (previous version). I've squashed all the development commits into a single commit (but have included the development history in the commit message).

The documentation file (rank_spanning_branchings.html) describes the added code (rank_spanning_branchings.hpp). I've included two examples (rank-branchings1.cpp and rank-branchings2.cpp), the second of which reads an input file (branching_input.txt). I've also included a test routine (rank_branchings_test.cpp). I added the examples and the test to the corresponding Jam files. These have small conflicts with the development branch that I thought it might be better for the maintainers to resolve.

Thanks for your consideration, and best wishes.

Brad Meyer

[anadon]

I'm helping out with the PR backlog. Looks like you have feature additions, new documentation, no test, and new examples will be needed. Please add tests for your added features. This is to let you know and help me prioritize PR's.

[mbradle]

Thanks for the update. There are two examples included in the pull request:

example/rank-branchings1.cpp

and

example/rank-branchings2.cpp

Once compiled, they are executed as:

./rank-branchings1

and (for example)

./rank-branchings2 branching_input.txt -10

I've included the compilation of these in the example/Jamfile.v2.

There is also a test:

test/rank_branchings_test.cpp

Once compiled, this can be executed as (for example)

./rank_branchings_test 4 10

I've included it in the test/Jamfile.v2 file.

I notice above that two Travis builds failed on my complex graph for clang on linux. I can't find anything wrong with my file and have succeeded compiling and running the test code with clang-4.0 on a linux computer, so I wonder if there is an issue with the compiler on the test machine. Nevertheless, I suppose this needs to be addressed.

Best wishes.

[anadon]

I'm in the process of dealing with some other build and test failures. When I'm done with those, I'll have you rebase your changes on upstream and that may fix your problems. Thank you for following up!

[anadon]

Can you rebase your PR?

[mbradle]

I've squashed and reworded commits. I've rebased to boostorg:develop. I'm still seeing a couple of travis-ci failures that I can't reproduce on my end. Thanks, and best wishes.

[anadon]

You test around line 820 has a template faux pas, and is causing timeout errors. Better, but you still need to put in just a little more work. You're close!

[anadon]

I'll get to a proper review when I can. This week got really busy for me, sorry!

[anadon]

@mbradle It appears that you're still not rebased on boostorg/graph's devel branch. Please do so.

[anadon]

@mbradle Looking more closely now. It looks like you've done your job and everything does appear clear. I'll need to take more time to look through though. Please be patient while I catch up!

[mbradle]

Sorry, I rebased again before I saw your last message. I hope that's ok. Best wishes.

[anadon]

I have a couple of big, no change PR's you might want to keep an eye on.