geometry icon indicating copy to clipboard operation
geometry copied to clipboard

Update cmake scripts and add them to github actions

Open vissarion opened this issue 1 year ago • 1 comments

This PR:

  • creates github actions for cmake builds and tests (as discussed in https://github.com/boostorg/geometry/pull/1280#issuecomment-2104855981)
  • declares tests EXCLUDE_FROM_ALL (closes https://github.com/boostorg/geometry/issues/1282)
  • tests compilation with C++17 (with cmake is much simpler to separate building from running tests, see https://github.com/boostorg/geometry/pull/1273)
  • adds some missing tests in cmake (such as index)

vissarion avatar Aug 14 '24 12:08 vissarion

Cool PR, I review later

barendgehrels avatar Aug 20 '24 06:08 barendgehrels

@barendgehrels thansk for the review and the comments. I addressed them all. Only the discussion on the c++ standard needs some check.

vissarion avatar Sep 06 '24 10:09 vissarion

Thanks for handling everything, completely fine!

barendgehrels avatar Sep 13 '24 12:09 barendgehrels

Why does boost::geometry depend on Boost::program_options and Boost::crc now? It shouldn't be in the public interface as it's only used in tests.

Osyotr avatar May 07 '25 23:05 Osyotr