geometry icon indicating copy to clipboard operation
geometry copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

Support covered_by() for box, geometry combinations

Open vissarion opened this issue 2 years ago • 1 comments

This PR implements support for covered_by() for the following combinations of a box and a geometry:

  • convered_by(box, areal) (only cartesian CS)
  • convered_by(geometry, box)

The first case resolves issue https://github.com/boostorg/geometry/issues/604

vissarion avatar Jul 28 '22 13:07 vissarion

@awulkiew thanks for your comments I addressed them by pushing new commits.

vissarion avatar Aug 30 '22 14:08 vissarion

@barendgehrels are you OK with this PR?

vissarion avatar Oct 12 '22 09:10 vissarion

@barendgehrels are you OK with this PR?

See my review remark, basically yes, but can you look at my comments I made earlier?

barendgehrels avatar Oct 12 '22 10:10 barendgehrels

@barendgehrels are you OK with this PR?

See my review remark, basically yes, but can you look at my comments I made earlier?

Thanks for the review! Somehow your comments appeared to me yesterday. I addressed them and now I can merge this PR.

vissarion avatar Oct 13 '22 08:10 vissarion