core icon indicating copy to clipboard operation
core copied to clipboard

Add pilfer to Core

Open vinniefalco opened this issue 3 years ago • 5 comments

Add pilfer to Core so that it can be used by more than just Boost.JSON

vinniefalco avatar May 15 '22 23:05 vinniefalco

I don't understand what's this about. Closing as spam.

@vinniefalco Please be clear about the problem description in future issues and avoid jargonisms.

Lastique avatar May 16 '22 11:05 Lastique

It's a request to add pilfer to Core. pilfer currently exists in Boost.JSON detail, and has been proposed by me in P0308.

That'd actually be a legitimate addition to Core, for a change - the component is already present in another library and is needed as common infrastructure in others.

pdimov avatar May 16 '22 11:05 pdimov

See: https://github.com/boostorg/json/blob/98d37f93706b50fd057d14bd241a2bfbcfec1527/include/boost/json/pilfer.hpp#L27

vinniefalco avatar May 16 '22 12:05 vinniefalco

You may want to reconsider the name. This facility is a optimization on move semantics, and is thus special-purpose and less widely used. In such cases we should consider a longer, more expressive name, such as semi_destructive_move(), to make it more likely that arbitrary users understand the code without having to read up on "pilfering".

breese avatar May 16 '22 13:05 breese

I like pilfer

vinniefalco avatar May 16 '22 15:05 vinniefalco