compute icon indicating copy to clipboard operation
compute copied to clipboard

is_contiguous_iterator should be a public customization point

Open jbytheway opened this issue 10 years ago • 3 comments

Currently the library specializes is_contiguous_iterator for containers it knows to have contiguous iterators. However, it seems likely that users will have their own vector-like containers (indeed, there are several in Boost already). It would be helpful if is_contiguous_iterator was a documented customization point by which users could mark their own iterators as contiguous.

(Indeed, the library already misses one standard one: std::string::iterator)

jbytheway avatar Dec 31 '14 04:12 jbytheway

I agree, this would probably be better to have in the public API. There have been some discussions in the past (http://lists.boost.org/boost-users/2013/03/78146.php) to add this sort of trait somewhere more general in Boost (perhaps Boost.TypeTraits). If possible I'd like this trait to actually live elsewhere as I feel it is generally useful, but for now I can add it to the Boost.Compute public API.

kylelutz avatar Dec 31 '14 05:12 kylelutz

Indeed, it would be even better if it were central. Indeed, there's a proposal to have it in std (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4183.pdf) but that will be a while...

jbytheway avatar Dec 31 '14 05:12 jbytheway

I imagine if you made a pull request for Boost.TypeTraits it would be looked on favourably.

jbytheway avatar Dec 31 '14 13:12 jbytheway