build icon indicating copy to clipboard operation
build copied to clipboard

Please add OS for GNU/Hurd and GNU/kFreeBSD

Open mirabilos opened this issue 6 years ago • 2 comments

While on adding platforms anyway, please add BOOST_OS_HURD.

On GNU/Hurd, the C præprocessor define __GNU__ is defined, for detection.

See the thread around https://lists.debian.org/debian-hurd/2019/07/msg00045.html where the Hurd porters told me that Boost currently does not have an OS defined for them.

Thanks in advance!

mirabilos avatar Aug 06 '19 18:08 mirabilos

Judging from the latest kfreebsd-amd64 build log, there’s also no OS definition for GNU/kFreeBSD (the FreeBSD kernel with GNU userland).

The build fails because neither BOOST_OS_BSD nor BOOST_OS_LINUX are defined… which is, incidentally, proper, because one needs to use some BSD and some GNU methods on this hybrid operating system; BOOST_OS_KFREEBSD would work in addition to BOOST_OS_HURD.

Or we can just use…

#elif defined(__FreeBSD_kernel__) && defined(__GLIBC__)

… to check for it (an and of both is needed to distinguish from regular FreeBSD, and from any system using GNU libc), but then I wonder what these abstractions are for.

(In this specific case, I’d probably use the BSD variant of the code, as it calls a kernel function I assume would still work, but with linprocfs mounted, the Linux one would also work. But, as I said, this cannot be generalised.)

mirabilos avatar Aug 15 '19 17:08 mirabilos

Thank you for your contributions. Main development of B2 has moved to https://github.com/bfgroup/b2 This issue has been automatically marked as "transition" to indicate the potential for needing transition to the new B2 development project.

stale[bot] avatar Jun 11 '21 01:06 stale[bot]