beast icon indicating copy to clipboard operation
beast copied to clipboard

Remove BOOST_BEAST_USE_STD_STRING_VIEW

Open sehe opened this issue 3 years ago • 5 comments

Fixes #2363

sehe avatar Jun 15 '22 14:06 sehe

An automated preview of the documentation is available at https://2451.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

cppalliance-bot avatar Jun 15 '22 14:06 cppalliance-bot

We can't just remove it, we have to deprecate it first for at least one release

vinniefalco avatar Jun 21 '22 23:06 vinniefalco

Does that include a preprocessor warning (well, error, for portability) when it's used? Or just a deprecation notice in the release notes

sehe avatar Jun 22 '22 14:06 sehe

it should be an error or warning unless they define BOOST_BEAST_ALLOW_DEPRECATED or something like that.

vinniefalco avatar Jun 22 '22 17:06 vinniefalco

An automated preview of the documentation is available at https://2451.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

cppalliance-bot avatar Oct 02 '22 13:10 cppalliance-bot

This needs to be squashed, with authorship preserved, and the commit message edited to reflect the semantics of the change, i.e. "std::string_view is not an option"

vinniefalco avatar Oct 02 '22 19:10 vinniefalco

An automated preview of the documentation is available at https://2451.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

cppalliance-bot avatar Oct 03 '22 02:10 cppalliance-bot

An automated preview of the documentation is available at https://2451.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

cppalliance-bot avatar Oct 03 '22 03:10 cppalliance-bot

Codecov Report

Merging #2451 (6869502) into develop (12c2d14) will not change coverage. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2451   +/-   ##
========================================
  Coverage    94.72%   94.72%           
========================================
  Files          152      152           
  Lines        11881    11881           
========================================
  Hits         11254    11254           
  Misses         627      627           
Impacted Files Coverage Δ
include/boost/beast/core/string_type.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12c2d14...6869502. Read the comment docs.

codecov[bot] avatar Oct 03 '22 04:10 codecov[bot]