beast
beast copied to clipboard
s390x architecture drone jobs
Why is this failing?
There might be issues with the specific commit this branch diverged from. I will rebase and push to the pull request again.
Timeline tracing charts: https://2389.beast.tracing.cppalliance.org/index.html
@alandefreitas if this doesn't fail we should merge it
It does fail in the new architecture.
the tests try to link to coroutine, which doesn't work
(Peter)
Boost context supports s390 - will investigate.
@sdarwin it looks like boost.context needs you to explicitly add architecture=s390x
for it to pick up the right assembly file. I could possibly hack something together, but I reckon it's better if you add that parameter the proper way.
https://github.com/boostorg/context/blob/5852b493554ba8be5459147abf226f57d6bfa74c/build/Jamfile.v2#L473
needs you to explicitly add architecture=s390x
@klemens-morgenstern it does sound like a good idea. boostorg/boost-ci is missing an option for 'architecture' so I added that and tested. Here are results. https://drone.cpp.al/samd2/beast/239
As before, s390x gcc is being detected and completes successfully. It works even without specifying architecture.
s390x clang fails to be detected. This happens even when specifying architecture. In the drone job logs, here is what is being executed:
./b2 libs/beast/test toolset=clang cxxstd=11,14,17,20 architecture=s390x variant=release -j4
Oh, that's an issue in the build script of context
- I'll create a PR.
@klemens-morgenstern nice work. Switching from clang-12 to clang-14 solved it. However the update to boostorg/context is still required, and they haven't merged it, so this pull request will still show errors.
Timeline tracing charts: https://2389.beast.tracing.cppalliance.org/index.html
Codecov Report
Merging #2389 (1bfad42) into develop (5799f15) will increase coverage by
0.01%
. The diff coverage isn/a
.
Additional details and impacted files
@@ Coverage Diff @@
## develop #2389 +/- ##
===========================================
+ Coverage 94.72% 94.74% +0.01%
===========================================
Files 152 153 +1
Lines 11858 12066 +208
===========================================
+ Hits 11233 11432 +199
- Misses 625 634 +9
Impacted Files | Coverage Δ | |
---|---|---|
include/boost/beast/core/impl/buffers_adaptor.hpp | 97.80% <0.00%> (-0.87%) |
:arrow_down: |
include/boost/beast/websocket/detail/impl_base.hpp | 85.71% <0.00%> (-0.78%) |
:arrow_down: |
include/boost/beast/websocket/impl/stream.hpp | 73.78% <0.00%> (-0.71%) |
:arrow_down: |
include/boost/beast/websocket/impl/read.hpp | 96.49% <0.00%> (-0.68%) |
:arrow_down: |
include/boost/beast/websocket/impl/accept.hpp | 98.44% <0.00%> (-0.15%) |
:arrow_down: |
include/boost/beast/http/fields.hpp | 100.00% <0.00%> (ø) |
|
include/boost/beast/core/async_base.hpp | 100.00% <0.00%> (ø) |
|
include/boost/beast/core/rate_policy.hpp | 80.00% <0.00%> (ø) |
|
include/boost/beast/core/string_type.hpp | 100.00% <0.00%> (ø) |
|
include/boost/beast/websocket/stream.hpp | 100.00% <0.00%> (ø) |
|
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5799f15...1bfad42. Read the comment docs.