booster icon indicating copy to clipboard operation
booster copied to clipboard

Read Models projections by ReadModel query

Open gonzalojaubert opened this issue 1 year ago • 16 comments

TODO refactor

gonzalojaubert avatar Oct 16 '23 08:10 gonzalojaubert

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Oct 16 '23 08:10 ghost

/integration sha=8b61944

gonzalogarciajaubert avatar Nov 21 '23 14:11 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 21 '23 14:11 github-actions[bot]

:x: Oh no! Integration tests have failed

github-actions[bot] avatar Nov 21 '23 15:11 github-actions[bot]

/integration sha=f4dbdab

gonzalogarciajaubert avatar Nov 22 '23 12:11 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 22 '23 12:11 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Nov 22 '23 13:11 github-actions[bot]

/integration sha=c0d2976

gonzalogarciajaubert avatar Nov 23 '23 12:11 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 23 '23 12:11 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Nov 23 '23 13:11 github-actions[bot]

/integration sha=7662e4adde9c4fc2fbabc04177a9891c6ab7ee2a

MarcAstr0 avatar Apr 19 '24 14:04 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Apr 19 '24 14:04 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Apr 19 '24 14:04 github-actions[bot]

/integration sha=a690096

MarcAstr0 avatar Jun 12 '24 13:06 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 12 '24 13:06 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jun 12 '24 14:06 github-actions[bot]

/integration sha=fb763a60b77ed42c7bf7fbd66e35a1150e4992ea

MarcAstr0 avatar Jul 22 '24 15:07 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jul 22 '24 15:07 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jul 22 '24 16:07 github-actions[bot]

In a first look addressing the tests and documentation, I have commented some lines of the codes pointing out issues about naming of functions. Maybe I'm being a bit nitpicky, but Booster is opinionated and for example, naming a function update inside a ReadModel is misleading (ReadModels implement Query operations and not update/insert operations as in Commands). We can see good examples in the official documentation:

  • https://docs.boosterframework.com/architecture/read-model
  • https://docs.boosterframework.com/architecture/entity

Tomorrow I'll add the reviews on the rest of the code

davidverdu avatar Jul 29 '24 16:07 davidverdu

@davidverdu your suggestions related to method names have been applied in commit 393fade1a4102552e88f6d7d8105abc9d15df9ac :wink: :+1:

MarcAstr0 avatar Jul 29 '24 21:07 MarcAstr0

/integration sha=393fade

davidverdu avatar Jul 30 '24 09:07 davidverdu

/integration sha=393fade

davidverdu avatar Jul 30 '24 09:07 davidverdu

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jul 30 '24 09:07 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jul 30 '24 11:07 github-actions[bot]

/integration sha=a8c41f62c132e58176f9d976945804dfe3fc4cd4

MarcAstr0 avatar Jul 30 '24 15:07 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jul 30 '24 15:07 github-actions[bot]

@davidverdu your comments about access modifiers and some method names in the ReadModelStore class have been addressed in commit 1786d58d0167e3e16ecb19db614fac40ceaebebf.

MarcAstr0 avatar Jul 30 '24 15:07 MarcAstr0

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jul 30 '24 16:07 github-actions[bot]