booster
booster copied to clipboard
Read Models projections by ReadModel query
TODO refactor
/integration sha=8b61944
:x: Oh no! Integration tests have failed
/integration sha=f4dbdab
:white_check_mark: Integration tests have finished successfully!
/integration sha=c0d2976
:white_check_mark: Integration tests have finished successfully!
/integration sha=7662e4adde9c4fc2fbabc04177a9891c6ab7ee2a
:white_check_mark: Integration tests have finished successfully!
/integration sha=a690096
:white_check_mark: Integration tests have finished successfully!
/integration sha=fb763a60b77ed42c7bf7fbd66e35a1150e4992ea
:white_check_mark: Integration tests have finished successfully!
In a first look addressing the tests and documentation, I have commented some lines of the codes pointing out issues about naming of functions. Maybe I'm being a bit nitpicky, but Booster is opinionated and for example, naming a function update
inside a ReadModel is misleading (ReadModels implement Query operations and not update/insert operations as in Commands). We can see good examples in the official documentation:
- https://docs.boosterframework.com/architecture/read-model
- https://docs.boosterframework.com/architecture/entity
Tomorrow I'll add the reviews on the rest of the code
@davidverdu your suggestions related to method names have been applied in commit 393fade1a4102552e88f6d7d8105abc9d15df9ac :wink: :+1:
/integration sha=393fade
/integration sha=393fade
:white_check_mark: Integration tests have finished successfully!
/integration sha=a8c41f62c132e58176f9d976945804dfe3fc4cd4
@davidverdu your comments about access modifiers and some method names in the ReadModelStore
class have been addressed in commit 1786d58d0167e3e16ecb19db614fac40ceaebebf.
:white_check_mark: Integration tests have finished successfully!