booster icon indicating copy to clipboard operation
booster copied to clipboard

Replace nedb with fork `@seald-io/nedb`

Open gonzalojaubert opened this issue 1 year ago • 23 comments

Replace nedb with seald/nedb fork

End to end - Local provider integration tests fixed

gonzalojaubert avatar Jul 26 '23 15:07 gonzalojaubert

/integration sha=53d5270

gonzalogarciajaubert avatar Jul 26 '23 15:07 gonzalogarciajaubert

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Jul 26 '23 15:07 ghost

PR Summary

  • Shift in Datastore Dependency The code was updated in several places to use @seald-io/nedb instead of nedb. This is a slight modification with potentially better performance and improved overall efficiency.

  • Expect Helper Migration In provider-unaware end-to-end integration tests, the utility to assert expected results is now sourced from a local helper instead of a third-party library. This update provides precise control over the assertion mechanism.

  • File Renaming The subscriptions integration test file was moved to a more appropriately named directory to better document its responsibility.

  • Dependency Updates in package.json Files The package.json files were updated to replace the nedb dependency with @seald-io/nedb. Furthermore, the @types/nedb was removed from development dependencies suggesting a more straightforward dependency structure.

  • Datastore Initialization Updates In several services, the loadDatabase method was replaced with an autoload: true parameter when initializing the datastore. This makes for a cleaner, more effective database loading process.

  • Transition to Async Methods In the event registry and read model registry tests, various methods were switched from synchronous to their asynchronous counterparts for efficient, non-blocking operations.

what-the-diff[bot] avatar Jul 26 '23 15:07 what-the-diff[bot]

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jul 26 '23 15:07 github-actions[bot]

:x: Oh no! Integration tests have failed

github-actions[bot] avatar Jul 26 '23 16:07 github-actions[bot]

/integration sha=6944e40

gonzalogarciajaubert avatar Jul 28 '23 14:07 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jul 28 '23 14:07 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jul 28 '23 15:07 github-actions[bot]

/integration sha=b7e72ea

gonzalogarciajaubert avatar Aug 21 '23 09:08 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Aug 21 '23 09:08 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Aug 21 '23 10:08 github-actions[bot]

/integration sha=15aeb32

gonzalogarciajaubert avatar Nov 27 '23 12:11 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 27 '23 12:11 github-actions[bot]

:x: Oh no! Integration tests have failed

github-actions[bot] avatar Nov 27 '23 12:11 github-actions[bot]

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 27 '23 12:11 github-actions[bot]

:x: Oh no! Integration tests have failed

github-actions[bot] avatar Nov 27 '23 12:11 github-actions[bot]

/integration sha=fc643f7

gonzalogarciajaubert avatar Nov 27 '23 13:11 gonzalogarciajaubert

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 27 '23 13:11 github-actions[bot]

:x: Oh no! Integration tests have failed

github-actions[bot] avatar Nov 27 '23 13:11 github-actions[bot]

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 27 '23 14:11 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Nov 27 '23 14:11 github-actions[bot]

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Nov 27 '23 14:11 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Nov 27 '23 15:11 github-actions[bot]

/integration sha=0b8c70fe3a76fcd7aaddc7d3a7da82cff12d0f70

MarcAstr0 avatar Mar 21 '24 15:03 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Mar 21 '24 15:03 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Mar 21 '24 16:03 github-actions[bot]