booster icon indicating copy to clipboard operation
booster copied to clipboard

Add global event handler

Open gonzalojaubert opened this issue 1 year ago • 1 comments

Description

Add a global event handler

Checks

  • [X] Project Builds
  • [X] Project passes tests and checks
  • [X] Updated documentation accordingly

gonzalojaubert avatar May 09 '23 14:05 gonzalojaubert

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar May 09 '23 14:05 ghost

About commit f9b730e: this commit fixes an issue introduced in v2.11 (related to PR #1481).

The issue in question is changing Cosmos DB SQL queries so they use square brackets instead of dot notation for properties. i.e., a SQL query such as SELECT c.id FROM c is changed to SELECT c["id"] FROM c.

This prevents that Cosmos throws syntax errors when there are properties in the read model that are also reserved Cosmos DB keywords (e.g., value). This issue was found when running this integration test.

MarcAstr0 avatar Jun 05 '24 15:06 MarcAstr0

/integration sha=f9b730e8b88d6b0004f08eb0637f66ebfaffcd12

MarcAstr0 avatar Jun 05 '24 19:06 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 05 '24 19:06 github-actions[bot]

:x: Oh no! Integration tests have failed

github-actions[bot] avatar Jun 05 '24 20:06 github-actions[bot]

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 05 '24 20:06 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jun 05 '24 20:06 github-actions[bot]

/integration sha=ac8e2bd377f47f9d9853e917f736a6229a831640

MarcAstr0 avatar Jun 06 '24 17:06 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 06 '24 17:06 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jun 06 '24 18:06 github-actions[bot]

/integration sha=3ef5080f0197c4e895d6e332114a9881fe7f5601

MarcAstr0 avatar Jun 07 '24 12:06 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 07 '24 12:06 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jun 07 '24 13:06 github-actions[bot]

/integration sha=1aeaf9c

MarcAstr0 avatar Jun 07 '24 15:06 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 07 '24 15:06 github-actions[bot]

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jun 07 '24 16:06 github-actions[bot]

/integration sha=4b970ce91b45f61a52da045a7e46f5b06cc96f8c

MarcAstr0 avatar Jun 11 '24 14:06 MarcAstr0

:hourglass: Integration tests are running...

Check their status here 👈

github-actions[bot] avatar Jun 11 '24 14:06 github-actions[bot]

@alvaroloes your suggestions have been applied in commit 4b970ce91b45f61a52da045a7e46f5b06cc96f8c

MarcAstr0 avatar Jun 11 '24 14:06 MarcAstr0

:white_check_mark: Integration tests have finished successfully!

github-actions[bot] avatar Jun 11 '24 15:06 github-actions[bot]

Closes PR #1535

MarcAstr0 avatar Jun 11 '24 15:06 MarcAstr0