booster icon indicating copy to clipboard operation
booster copied to clipboard

Published 20 hours ago • verified publisher icon boostercloud

chore: run unit tests on multiple node versions

Open spnraju opened this issue 3 years ago • 3 comments

Description

Fixes #1118 : updating GitHub workflow to run unit tests on multiple versions (14, 16, and 18) of nodejs

Changes

Added a matrix to Github actions for unit tests. This helps in running tests on multiple Nodejs versions.

Checks

  • [ ] Project Builds
  • [ ] Project passes tests and checks
  • [ ] Updated documentation accordingly

spnraju avatar Jul 19 '22 21:07 spnraju

Woah thanks for this! Let's see how well it fares against multiple versions 😅

NickSeagull avatar Jul 21 '22 11:07 NickSeagull

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Sep 10 '22 19:09 ghost

Hello @spnraju , we're currently moving a lot of stuff in the 1.0.0 branch, mainly switching build tools. This PR hasn't been merged because it'd make all PRs to fail to merge, and for now everything (at least) works in 16.

As soon as 1.0.0 gets merged, we'll take action on this PR and make sure it builds with all node versions. Thanks a lot!

NickSeagull avatar Oct 03 '22 10:10 NickSeagull

This PR would need to be reworked as we've migrated to MS Rush since it was opened. I'll close it and let @NickSeagull decide the next steps, as he's currently reworking the CI/CD processes.

javiertoledo avatar Dec 19 '22 16:12 javiertoledo