buddypress-group-email-subscription icon indicating copy to clipboard operation
buddypress-group-email-subscription copied to clipboard

Emails sent to members who have "No Email" set

Open iamkevinjohnson opened this issue 1 year ago • 7 comments

Emails sent to members who have "No Email" set

iamkevinjohnson avatar Jun 16 '23 12:06 iamkevinjohnson

I am also experiencing this issue. "No email" is the default setting for all new users of a Group, but folks are still receiving email notifications for all activity.

johnmetzler avatar Jul 26 '23 18:07 johnmetzler

Same here. My clients are using Buddyboss.

contemplate avatar Jan 04 '24 18:01 contemplate

@boonebgorges in the past with Buddyboss issues you needed an updated plugin version to test.
When you are ready I can send you one. Thanks!

contemplate avatar Jan 04 '24 18:01 contemplate

Hi all - I've tested against a vanilla installation of the latest BP + BPGES and have not been able to reproduce the problem. Things to check:

  • Look in the wp_bpges_subscriptions table and see if there are entries for the users in question. If so, what are they? Users with 'No Email' should have an entry that says no. If they have no entry at all in this table, this could be the root of the problem.
  • Are you certain that the emails are coming from BPGES? What kind of activity is triggering the emails? For example, bbPress forums can trigger email notifications that are unrelated to BPGES and would not be sensitive to the 'No email' setting.

@boonebgorges in the past with Buddyboss issues you needed an updated plugin version to test.

@contemplate Thanks for this. I'm not sure that this problem is related to BuddyBoss. But if it is, I'm afraid I don't have the bandwidth or the inclination to troubleshoot it. If someone is able to identify (in this case or others) specific changes to BPGES that would help with BuddyBoss compatibility, I will certainly consider them, but I cannot sink any time into researching them myself.

boonebgorges avatar Jan 04 '24 18:01 boonebgorges

@boonebgorges I looked at one of the users in the db table and the type is all set to no Screenshot 2024-01-04 at 9 25 12 PM

So I'm guessing they are receiving the default Buddyboss group email and a filter needs to be added to stop these if a digest entry is set. But perhaps an easier solution would be to simply draft these two email templates? Or does BPGES rely on these templates as well for the All Emails option? Screenshot 2024-01-04 at 9 31 45 PM

contemplate avatar Jan 05 '24 02:01 contemplate

@contemplate Thanks for sharing these screenshots. The first one indicates that the BPGES subscriptions are being properly recorded.

The second one suggests that the problematic emails are not, in fact, coming from BPGES. The email templates in your screenshot aren't from this plugin. See https://github.com/boonebgorges/buddypress-group-email-subscription/blob/1063628f719619cf387eaf8015705d4eaab2b17d/bp-activity-subscription-functions.php#L1076 and the subsequent clauses for the text you see in the 'Situations' column for BPGES emails. So this suggests the emails are coming from BuddyBoss. See https://github.com/buddyboss/buddyboss-platform/blob/19c8c1623a2320e2a0ee21b0127301e0484e665c/src/bp-core/bp-core-update.php#L2482. I don't know anything about BuddyBoss's own "group email" system - it's possible that it's supposed to work alongside BPGES, or perhaps it's meant to be used instead of BPGES. In any case, it's a question for the BuddyBoss support team, as they claim that any BP plugin should be compatible with BuddyBoss https://www.buddyboss.com/resources/docs/integrations/buddypress-add-ons/ but sometimes reality is a bit more complicated.

boonebgorges avatar Jan 05 '24 15:01 boonebgorges

ok @boonebgorges let me follow up with the Buddyboss team as you are right they do promote compatibility with BPGES. They recently have reworked their entire notification system so they may need to add a filter to see if BPGES is active and set to 'no' emails.

contemplate avatar Jan 05 '24 15:01 contemplate